Skip to content

docs: Add new PR response templates#47515

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:commit-template
Closed

docs: Add new PR response templates#47515
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:commit-template

Conversation

@jessicajaniuk
Copy link
Contributor

This adds new PR template responses for dealing with rebases and commit header changes. It should help reduce contributor confusion around commit header changes and rebasing.

@jessicajaniuk jessicajaniuk added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 21, 2022
@ngbot ngbot bot modified the milestone: Backlog Sep 21, 2022
@pullapprove pullapprove bot requested a review from josephperrott September 21, 2022 20:07
@jessicajaniuk jessicajaniuk added area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) and removed comp: docs labels Sep 21, 2022
This adds new PR template responses for dealing with rebases and commit header changes.
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 22, 2022
@alxhub
Copy link
Member

alxhub commented Sep 23, 2022

This PR was merged into the repository by commit 478db89.

alxhub pushed a commit that referenced this pull request Sep 23, 2022
This adds new PR template responses for dealing with rebases and commit header changes.

PR Close #47515
@alxhub alxhub closed this in 478db89 Sep 23, 2022
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Sep 27, 2022
This adds new PR template responses for dealing with rebases and commit header changes.

PR Close angular#47515
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2022
@jessicajaniuk jessicajaniuk deleted the commit-template branch April 5, 2023 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants