docs: visualize keyboard shortcut for search#47507
Closed
dzonatan wants to merge 1 commit intoangular:mainfrom
Closed
docs: visualize keyboard shortcut for search#47507dzonatan wants to merge 1 commit intoangular:mainfrom
dzonatan wants to merge 1 commit intoangular:mainfrom
Conversation
|
You can preview b84bdc8 at https://pr47507-b84bdc8.ngbuilds.io/. |
jessicajaniuk
approved these changes
Sep 21, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM 🍪
I actually quite like how this looks! It's consistent with github and other sites. Thanks for this!
Member
|
This PR was merged into the repository by commit 291a5b3. |
alxhub
pushed a commit
that referenced
this pull request
Sep 23, 2022
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Sep 27, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current/new behavior?
Currently, there is no visual guidance on how to jump straight to the search box via keyboard shortcut.
Presenting the keyboard shortcut right in the search bar is pretty common these days:
I didn't even know that Angular docs supports
/shortcut for this already.Would be a nice touch to show this the same way Github does.
Feel free to make any changes or reject, this is just a proposal.
Does this PR introduce a breaking change?