Skip to content

test(docs-infra): add mocks for missing mat-icons#47469

Closed
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:aio-fix-mat-icon-test-noise
Closed

test(docs-infra): add mocks for missing mat-icons#47469
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:aio-fix-mat-icon-test-noise

Conversation

@dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Sep 17, 2022 •
edited
Loading

add mocks for missing mat-icons in order to reduce noise when running aio tests

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

When running the aio tests a bunch of messages get displayed regarding an undeclared mat-icon:
Screenshot at 2022-09-17 22-53-59

What is the new behavior?

Mocks for the mat-icon component have been added to the tests so that the messages are not being displayed anymore

Does this PR introduce a breaking change?

  • Yes
  • No

@dario-piotrowicz
test(docs-infra): add mocks for missing mat-icons
1c61c4d 
add mocks for missing mat-icons in order to reduce noise when running
aio tests
@pullapprove pullapprove bot requested a review from gkalpak September 17, 2022 22:01
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra target: patch This PR is targeted for the next patch release labels Sep 19, 2022
@ngbot ngbot bot modified the milestone: Backlog Sep 19, 2022
gkalpak
gkalpak approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ❤️

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 19, 2022
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 19, 2022

This PR was merged into the repository by commit 14cb9fb.

pkozlowski-opensource pushed a commit that referenced this pull request Sep 19, 2022
@dario-piotrowicz @pkozlowski-opensource
test(docs-infra): add mocks for missing mat-icons (#47469)
08cd6e1 
add mocks for missing mat-icons in order to reduce noise when running
aio tests

PR Close #47469
@dario-piotrowicz dario-piotrowicz deleted the aio-fix-mat-icon-test-noise branch September 19, 2022 13:37
@alfaproject
Copy link
Contributor

alfaproject commented Sep 21, 2022

@dario-piotrowicz OOC wouldn't importing MatIconTestingModule be enough?

@dario-piotrowicz
Copy link
Contributor Author

dario-piotrowicz commented Sep 21, 2022

@dario-piotrowicz OOC wouldn't importing MatIconTestingModule be enough?

That module doesn't declare the component: https://github.com/angular/components/blob/2f9a59a24c0464cbed7f54cbeb5cba73e6007715/src/material/icon/testing/fake-icon-registry.ts

So it doesn't really solve our issue (I gave it a try and indeed adding it to the imports doesn't prevent the messages)

Unless I'm missing something? 🙂

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 22, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gkalpak gkalpak gkalpak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@dario-piotrowicz @pkozlowski-opensource @alfaproject @gkalpak