fix(docs-infra): initialize events arrays in EventsComponent#47458
Closed
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
Closed
fix(docs-infra): initialize events arrays in EventsComponent#47458dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
Conversation
initialize the events fields of the EventsComponent so that they are always defined
d1cfac1 to
16d2ef7
Compare
gkalpak
approved these changes
Sep 16, 2022
Member
|
This PR was merged into the repository by commit 5fb7ae2. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 16, 2022
initialize the events fields of the EventsComponent so that they are always defined PR Close #47458
vyom1611
pushed a commit
to vyom1611/angular
that referenced
this pull request
Sep 18, 2022
…#47458) initialize the events fields of the EventsComponent so that they are always defined PR Close angular#47458
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initialize the events fields of the EventsComponent so that they are always defined
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
When running the aio app locally the following warning gets shown in the terminal:
What is the new behavior?
The
upcomingEventsgets initialized to[], so it is always defined and no optional chaining is needed (I could have made the field optional and that would also have solved the issue, but I figured it could be cleaner to initialize the array instead)I've also initialized the
pastEventsfor consistency, it is also directly accessed without checks so I assume that it should be initialized (strangely, but I removed its assignment and I wasn't getting any runtime error...)Does this PR introduce a breaking change?