Skip to content

fix(docs-infra): apply text-top instead of top for table alignment#47457

Closed
dario-piotrowicz wants to merge 2 commits intoangular:mainfrom
dario-piotrowicz:47423
Closed

fix(docs-infra): apply text-top instead of top for table alignment#47457
dario-piotrowicz wants to merge 2 commits intoangular:mainfrom
dario-piotrowicz:47423

Conversation

@dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Sep 15, 2022

use text-top instead of top for table cells verical alignment so that the texts are correctly vertially aligned regardless on the dom structure

resolves #47423

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #47423

Before:
Screenshot at 2022-09-15 22-41-13

(it's pretty subtle but you can see that the code on the left placed lightly higher)

What is the new behavior?

After:

Screenshot at 2022-09-15 22-41-23

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from gkalpak September 15, 2022 21:43
@dario-piotrowicz
fix(docs-infra): apply text-top instead of top for table alignment
cb3adac 
use `text-top` instead of `top` for table cells verical alignment
so that the texts are correctly vertially aligned regardless on
the dom structure

resolves angular#47423
@dario-piotrowicz dario-piotrowicz changed the title fix(aio): apply text-top instead of top for table alignment fix(docs-infra): apply text-top instead of top for table alignment Sep 15, 2022
gkalpak
gkalpak suggested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @dario-piotrowicz!
One minor suggestion. Otherwise lgtm 👏

@ngbot ngbot bot added this to the Backlog milestone Sep 16, 2022
@pkozlowski-opensource pkozlowski-opensource added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Sep 16, 2022
gkalpak
gkalpak approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @dario-piotrowicz 👍

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 19, 2022
@ngbot
Copy link

ngbot bot commented Sep 19, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 19, 2022

This PR was merged into the repository by commit a192c2d.

pkozlowski-opensource pushed a commit that referenced this pull request Sep 19, 2022
@dario-piotrowicz @pkozlowski-opensource
fix(docs-infra): apply text-top instead of top for table alignment (
e563139 
#47457)

use `text-top` instead of `top` for table cells verical alignment
so that the texts are correctly vertially aligned regardless on
the dom structure

resolves #47423

PR Close #47457
@dario-piotrowicz dario-piotrowicz deleted the 47423 branch September 19, 2022 13:38
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 20, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gkalpak gkalpak gkalpak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

docs: Horizontal alignment issue in https://angular.io/guide/what-is-angular angular

3 participants

@dario-piotrowicz @pkozlowski-opensource @gkalpak