Skip to content

docs(docs-infra): add missing decorator in tutorial step#47456

Closed
mauromattos00 wants to merge 1 commit intoangular:mainfrom
mauromattos00:missing-decorator-fix
Closed

docs(docs-infra): add missing decorator in tutorial step#47456
mauromattos00 wants to merge 1 commit intoangular:mainfrom
mauromattos00:missing-decorator-fix

Conversation

@mauromattos00
Copy link
Contributor

@mauromattos00 mauromattos00 commented Sep 15, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The @Injectable decorator is missing in tutorial step

Issue Number: #47425

What is the new behavior?

The decorator is being shown in the step, which can help devs not to forget to import it.

Does this PR introduce a breaking change?

  • Yes
  • No

@google-cla
Copy link

google-cla bot commented Sep 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from AndrewKushnir September 15, 2022 21:17
@ngbot ngbot bot added this to the Backlog milestone Sep 15, 2022
@AndrewKushnir AndrewKushnir added aio: preview target: patch This PR is targeted for the next patch release labels Sep 16, 2022
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer action: rerun CI at HEAD labels Sep 16, 2022
@mary-poppins
Copy link

mary-poppins commented Sep 16, 2022

You can preview b88544a at https://pr47456-b88544a.ngbuilds.io/.

AndrewKushnir
AndrewKushnir approved these changes Sep 17, 2022
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauromattos00 thanks for improving Angular docs!

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 17, 2022
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 19, 2022

This PR was merged into the repository by commit ad098d8.

pkozlowski-opensource pushed a commit that referenced this pull request Sep 19, 2022
@mauromattos00 @pkozlowski-opensource
docs(docs-infra): add missing decorator in tutorial step (#47456)
1b42b04 
PR Close #47456
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 20, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@mauromattos00 @mary-poppins @pkozlowski-opensource @AndrewKushnir