Skip to content

fix(docs-infra): fix Update AIO events GitHub Action#47452

Closed
gkalpak wants to merge 1 commit intoangular:mainfrom
gkalpak:fix-aio-update-events-workflow
Closed

fix(docs-infra): fix Update AIO events GitHub Action#47452
gkalpak wants to merge 1 commit intoangular:mainfrom
gkalpak:fix-aio-update-events-workflow

Conversation

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Sep 15, 2022

Previously, the Update AIO events GitHub Action was using a version of the create-pr-for-changes GitHub Action that relied on a GitHub App key for Angular Robot. This, however, prevented PRs from being created from the accounts fork.

Switch to a newer version of the create-pr-for-changes action that uses a GitHub Personal Access Token instead.

This is blocked on:

  • Adding a ANGULAR_ROBOT_ACCESS_TOKEN GitHub Action secret.

Previously, the `Update AIO events` GitHub Action was using a version of
the `create-pr-for-changes` GitHub Action that relied on a GitHub App
key for Angular Robot. This, however, prevented PRs from being created
from the accounts fork.

Switch to a newer version of the `create-pr-for-changes` action that
uses a GitHub Personal Access Token instead.
@gkalpak gkalpak added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra target: patch This PR is targeted for the next patch release labels Sep 15, 2022
@ngbot ngbot bot modified the milestone: Backlog Sep 15, 2022
@gkalpak gkalpak marked this pull request as ready for review September 15, 2022 13:47
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer state: blocked labels Sep 15, 2022
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 4eff4d3.

pkozlowski-opensource pushed a commit that referenced this pull request Sep 16, 2022
Previously, the `Update AIO events` GitHub Action was using a version of
the `create-pr-for-changes` GitHub Action that relied on a GitHub App
key for Angular Robot. This, however, prevented PRs from being created
from the accounts fork.

Switch to a newer version of the `create-pr-for-changes` action that
uses a GitHub Personal Access Token instead.

PR Close #47452
@gkalpak gkalpak deleted the fix-aio-update-events-workflow branch September 16, 2022 11:10
vyom1611 pushed a commit to vyom1611/angular that referenced this pull request Sep 18, 2022
Previously, the `Update AIO events` GitHub Action was using a version of
the `create-pr-for-changes` GitHub Action that relied on a GitHub App
key for Angular Robot. This, however, prevented PRs from being created
from the accounts fork.

Switch to a newer version of the `create-pr-for-changes` action that
uses a GitHub Personal Access Token instead.

PR Close angular#47452
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants