Skip to content

docs: add link to YouTube video of Typed Forms#47361

Closed
bob-watson wants to merge 1 commit intoangular:mainfrom
bob-watson:issue-47360
Closed

docs: add link to YouTube video of Typed Forms#47361
bob-watson wants to merge 1 commit intoangular:mainfrom
bob-watson:issue-47360

Conversation

@bob-watson
Copy link
Contributor

Fix: #47360

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

https://angular.io/guide/typed-forms doesn't have a link to the intro video

Issue Number: #47360

What is the new behavior?

https://angular.io/guide/typed-forms has a link to the intro video

Does this PR introduce a breaking change?

  • Yes
  • No

@bob-watson bob-watson added comp: docs target: patch This PR is targeted for the next patch release labels Sep 6, 2022
@ngbot ngbot bot modified the milestone: Backlog Sep 6, 2022
@pullapprove pullapprove bot requested a review from dylhunn September 6, 2022 18:17
@mary-poppins
Copy link

You can preview aa7f295 at https://pr47361-aa7f295.ngbuilds.io/.

Copy link
Member

@simonaco simonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eneajaho
Copy link
Contributor

eneajaho commented Sep 6, 2022

Hi,

It would be better if there was some space between the title and the video.
Also, I think having the iframe video width set to 100% will make it look better.

image

@bob-watson
Copy link
Contributor Author

eneajaho Thanks for the feedback.

I looked at making it full-width, but that pushes the following content further down the page--to the point that it would be out of the frame on smaller screens/windows. I want to promote the video, but not at the cost of the content.

I wanted to get this published to promote the video, even if the layout could be improved. Video content is still somewhat novel for AIO and we're still experimenting with how best to incorporate it.

Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-forms

@dylhunn
Copy link
Contributor

dylhunn commented Sep 12, 2022

Hey look, it's me! Feel free to mark for merge when you're ready, Bob.

@bob-watson bob-watson added the action: merge The PR is ready for merge by the caretaker label Sep 19, 2022
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 58e3d79.

@bob-watson bob-watson deleted the issue-47360 branch September 20, 2022 14:45
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add typed forms video to documentation

6 participants