refactor(router): Update error message when Router is provided twice#47130
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
refactor(router): Update error message when Router is provided twice#47130atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
80e9fca to
cfeef73
Compare
The current error message is absolute in that it thinks there is only one possible way to provide Router twice. In fact, you can get a new instance of the Router in several ways so the error message should indicate the exact failure case with a _potential_ cause. Based on findings in thread angular@0cbbd6a#commitcomment-80900192
cfeef73 to
7a5bdca
Compare
Member
|
This PR was merged into the repository by commit 93289f9. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Aug 12, 2022
…47130) The current error message is absolute in that it thinks there is only one possible way to provide Router twice. In fact, you can get a new instance of the Router in several ways so the error message should indicate the exact failure case with a _potential_ cause. Based on findings in thread 0cbbd6a#commitcomment-80900192 PR Close #47130
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current error message is absolute in that it thinks there is only
one possible way to provide Router twice. In fact, you can get a new
instance of the Router in several ways so the error message should
indicate the exact failure case with a potential cause.
Based on findings in thread 0cbbd6a#commitcomment-80900192