Skip to content

docs: rename duplicate header#47110

Closed
sonukapoor wants to merge 1 commit intoangular:mainfrom
sonukapoor:fix/47108/fix-di-doc
Closed

docs: rename duplicate header#47110
sonukapoor wants to merge 1 commit intoangular:mainfrom
sonukapoor:fix/47108/fix-di-doc

Conversation

@sonukapoor
Copy link
Contributor

@sonukapoor sonukapoor commented Aug 10, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #47108

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mary-poppins
Copy link

You can preview 56f4b38 at https://pr47110-56f4b38.ngbuilds.io/.

@ngbot ngbot bot added this to the Backlog milestone Aug 10, 2022
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Aug 10, 2022
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonukapoor thanks for improving Angular docs 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 10, 2022
@ngbot
Copy link

ngbot bot commented Aug 10, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 10, 2022
@AndrewKushnir
Copy link
Contributor

Merge-assistance: the "size" CI check failure looks unrelated, so we can proceed with the merge.

@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 8d0d6d9.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2022
@sonukapoor sonukapoor deleted the fix/47108/fix-di-doc branch October 15, 2022 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants