Skip to content

docs: add fatima amzil to contributors#47097

Closed
famzila wants to merge 1 commit intoangular:mainfrom
famzila:add-contributor
Closed

docs: add fatima amzil to contributors#47097
famzila wants to merge 1 commit intoangular:mainfrom
famzila:add-contributor

Conversation

@famzila
Copy link
Contributor

@famzila famzila commented Aug 9, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented Aug 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from twerske August 9, 2022 17:29
@jessicajaniuk jessicajaniuk added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Aug 9, 2022
@ngbot ngbot bot modified the milestone: Backlog Aug 9, 2022
@jessicajaniuk
Copy link
Contributor

@famzila Thanks for the PR! Looks like your image is above the limit of 30k. Can you fix that? When you do, either make it a fixup commit of squash it into your current commit. Thanks!

Copy link
Contributor

@twerske twerske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - welcome!

@jessicajaniuk jessicajaniuk added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 25, 2022
@bob-watson
Copy link
Contributor

bob-watson commented Sep 19, 2022

@famzila, it looks like the branch needs to be rebased on the current main branch. I updated the max image size test so your PR should pass that test. After you rebase the branch, it should rerun the CI test automatically.

@jessicajaniuk
Copy link
Contributor

@famzila @bob-watson I rebased this for you. We should be good to merge after CI finishes up.

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 19, 2022
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 150dd30.

@famzila
Copy link
Contributor Author

famzila commented Sep 20, 2022

Thank you, @jessicajaniuk. I've just checked the email about the rebase notification!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants