docs: Moving a div down in tutorial toh-pt6.md#47095
docs: Moving a div down in tutorial toh-pt6.md#47095aselunar wants to merge 1 commit intoangular:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
You can preview 219fe29 at https://pr47095-219fe29.ngbuilds.io/. |
|
@aselunar, Thanks for the update to the tutorial! |
bob-watson
left a comment
There was a problem hiding this comment.
The changes to the content look good.
There are just a couple of things to do before we can merge this change into the documentation:
- Submit a Contributor License Agreement so that we have your permission to use this update.
- Update your commit comment so that it starts with
docs:and describes the change this makes as described in the Contribution guidelines. We need this so that it'll be clear what this PR changes in the change log.
Thanks!
|
Done now. Thank you. |
|
You can preview af1b035 at https://pr47095-af1b035.ngbuilds.io/. |
|
This PR was merged into the repository by commit 777803c. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
At the point the "alert is-important" div is currently displayed, the Tour of Heroes app will not be working because the deleteHero method will not have been added to heroService. Therefore, I moved that div down to a point where it will be working, so the reader can try it out as intended.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
At the point the "alert is-important" div is currently displayed, the Tour of Heroes app will not be working because the deleteHero method will not have been added to heroService.
Issue Number: N/A
What is the new behavior?
Therefore, I moved that div down to a point where it will be working, so the reader can try it out as intended.
Does this PR introduce a breaking change?
Other information