build: update source-map package to latest version#46888
Closed
devversion wants to merge 6 commits intoangular:mainfrom
Closed
build: update source-map package to latest version#46888devversion wants to merge 6 commits intoangular:mainfrom
devversion wants to merge 6 commits intoangular:mainfrom
Conversation
The source-map package is updated as part angular#46707, but the minor version bump introduced breaking changes. This commit extracts the update so that we can handle it separately accounting for the breaking changes. Also removing the caret since this package apparently makes breaking changes in minor segment bumps.
…nal list The source-map package is no longer explicitly used in the `compiler-cli` package and therefore can be removed from the ESBuild bundling, denoting it as external. This should be a noop.
…ange The source-map package now requires the `SourceMapConsumer`/`SourceMapGenerator` classes to be instantiated asynchronously. This commit updates our tests to account for that.
The sourcemap test in the e2e playground is now using async/await code. This results in errors now with the Bazel TS compilation because it detects that `expect` is returning a promise and should be awaited. This happens due to the jasminewd2 types. We should just use the actual jasmine types and not rely on the deprecated selenium control flow, using explicit async/await in the whole test. This also solves the issue with the source-map types being async/await now.
… `fakeAsync` The source map tests rely on asynchronous logic from the `source-map` package. The tests itself are written using `fakeAsync` but this unnecessarily complicates the interaction with the asynchronous source-map helpers/package. To fix this, we just make the tests use async/await as we don't intend to test fakeAsync in this `describe` block..
devversion
commented
Jul 19, 2022
| load("//tools:defaults.bzl", "protractor_web_test_suite", "ts_library") | ||
|
|
||
| def example_test(name, srcs, server, data = [], deps = [], **kwargs): | ||
| def example_test(name, srcs, server, data = [], deps = [], use_legacy_webdriver_types = True, **kwargs): |
Member
Author
There was a problem hiding this comment.
Keeping this a default with True to minimize changes here... we need to clean up this modules directory at some point anyway I think.
atscott
approved these changes
Jul 19, 2022
Contributor
|
This PR was merged into the repository by commit 0dc754a. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 19, 2022
The source-map package is updated as part #46707, but the minor version bump introduced breaking changes. This commit extracts the update so that we can handle it separately accounting for the breaking changes. Also removing the caret since this package apparently makes breaking changes in minor segment bumps. PR Close #46888
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 19, 2022
The sourcemap test in the e2e playground is now using async/await code. This results in errors now with the Bazel TS compilation because it detects that `expect` is returning a promise and should be awaited. This happens due to the jasminewd2 types. We should just use the actual jasmine types and not rely on the deprecated selenium control flow, using explicit async/await in the whole test. This also solves the issue with the source-map types being async/await now. PR Close #46888
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 19, 2022
… `fakeAsync` (#46888) The source map tests rely on asynchronous logic from the `source-map` package. The tests itself are written using `fakeAsync` but this unnecessarily complicates the interaction with the asynchronous source-map helpers/package. To fix this, we just make the tests use async/await as we don't intend to test fakeAsync in this `describe` block.. PR Close #46888
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 19, 2022
The source-map package is updated as part #46707, but the minor version bump introduced breaking changes. This commit extracts the update so that we can handle it separately accounting for the breaking changes. Also removing the caret since this package apparently makes breaking changes in minor segment bumps. PR Close #46888
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 19, 2022
The sourcemap test in the e2e playground is now using async/await code. This results in errors now with the Bazel TS compilation because it detects that `expect` is returning a promise and should be awaited. This happens due to the jasminewd2 types. We should just use the actual jasmine types and not rely on the deprecated selenium control flow, using explicit async/await in the whole test. This also solves the issue with the source-map types being async/await now. PR Close #46888
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 19, 2022
… `fakeAsync` (#46888) The source map tests rely on asynchronous logic from the `source-map` package. The tests itself are written using `fakeAsync` but this unnecessarily complicates the interaction with the asynchronous source-map helpers/package. To fix this, we just make the tests use async/await as we don't intend to test fakeAsync in this `describe` block.. PR Close #46888
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 19, 2022
The sourcemap test in the e2e playground is now using async/await code. This results in errors now with the Bazel TS compilation because it detects that `expect` is returning a promise and should be awaited. This happens due to the jasminewd2 types. We should just use the actual jasmine types and not rely on the deprecated selenium control flow, using explicit async/await in the whole test. This also solves the issue with the source-map types being async/await now. PR Close #46888
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 19, 2022
… `fakeAsync` (#46888) The source map tests rely on asynchronous logic from the `source-map` package. The tests itself are written using `fakeAsync` but this unnecessarily complicates the interaction with the asynchronous source-map helpers/package. To fix this, we just make the tests use async/await as we don't intend to test fakeAsync in this `describe` block.. PR Close #46888
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits. Unblocks #46707