feat(core): update Injector.get and TestBed.inject to support object-based flags#46761
Closed
AndrewKushnir wants to merge 3 commits intoangular:mainfrom
Closed
feat(core): update Injector.get and TestBed.inject to support object-based flags#46761AndrewKushnir wants to merge 3 commits intoangular:mainfrom
Injector.get and TestBed.inject to support object-based flags#46761AndrewKushnir wants to merge 3 commits intoangular:mainfrom
Conversation
3553e1e to
01faada
Compare
Contributor
Author
01faada to
4b775fc
Compare
atscott
requested changes
Jul 12, 2022
4b775fc to
0857332
Compare
0857332 to
c64f54d
Compare
Contributor
Author
alxhub
reviewed
Jul 13, 2022
Member
alxhub
left a comment
There was a problem hiding this comment.
FYI, I think that modifying the signature of Injector.get is a breaking change. We should add the appropriate notice and push this to v15.
alxhub
requested changes
Sep 23, 2022
atscott
approved these changes
Sep 23, 2022
This commit applies the changes similar to the ones performed for the `inject()` function in angular@df246bb. The `Injector.get` function is updated to use previously added object-based API for options: now the flags argument supports passing an object which configures injection flags. DEPRECATED: The bit field signature of `Injector.get()` has been deprecated, in favor of the new options object.
This commit applies the changes similar to the ones performed for the `inject()` function in angular@df246bb. The `TestBed.inject` function is updated to use previously added object-based API for options: now the flags argument supports passing an object which configures injection flags. DEPRECATED: The bit field signature of `TestBed.inject()` has been deprecated, in favor of the new options object.
bab040d to
8690b13
Compare
8690b13 to
6159102
Compare
Contributor
Author
Contributor
Author
AndrewKushnir
added a commit
to AndrewKushnir/ngx-toastr
that referenced
this pull request
Sep 26, 2022
…njector.create This commit removes a custom ToastInjector (that provided a single token) in favor of creating a new injector instance using the `Injector.create` call. The goal of this change is to make the library forward-compatible with an upcoming change to the Injector interface, see angular/angular#46761.
alxhub
approved these changes
Sep 27, 2022
Contributor
Author
jessicajaniuk
approved these changes
Sep 27, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
jelbourn
approved these changes
Sep 27, 2022
Contributor
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
pkozlowski-opensource
approved these changes
Sep 27, 2022
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
Member
|
This PR was merged into the repository by commit 120555a. |
alxhub
pushed a commit
that referenced
this pull request
Sep 27, 2022
This commit applies the changes similar to the ones performed for the `inject()` function in df246bb. The `TestBed.inject` function is updated to use previously added object-based API for options: now the flags argument supports passing an object which configures injection flags. DEPRECATED: The bit field signature of `TestBed.inject()` has been deprecated, in favor of the new options object. PR Close #46761
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?