feat(core): add `createComponent` and `reflectComponentType` functions by AndrewKushnir · Pull Request #46685 · angular/angular

AndrewKushnir · 2022-07-02T02:39:55Z

See individual commits.

Resolves #45263 and #44926.

PR Type

What kind of change does this PR introduce?

Feature

Does this PR introduce a breaking change?

Yes
No

gund · 2022-07-04T14:34:46Z

This is great replacement for component factories!
However the naming maybe a bit confusing, maybe something like ComponentMetadata would be more appropriate to capture the intent instead of a ComponentMirror as it's not really mirroring anything but providing an extra "meta" information.

AndrewKushnir · 2022-07-08T01:51:20Z

@gund thanks for the feedback. We discussed this question with the team further and decided to rename the function to reflectComponentType.

packages/core/src/render3/component_ref.ts

packages/core/src/render3/errors.ts

pkozlowski-opensource

LGTM overall but I would like to discuss the API surface, see https://github.com/angular/angular/pull/46685/files#r916504416

atscott

LGTM assuming the change from createComponentRef -> createComponent is made, as discussed.

packages/core/src/render3/component_ref.ts

goldens/public-api/core/index.md

packages/core/src/render3/component.ts

packages/core/src/render3/component_ref.ts

AndrewKushnir · 2022-07-13T20:26:19Z

@alxhub thanks for the review, the comments are now addressed. Could you please take a final look at the public API when you get a chance? Thank you.

mary-poppins · 2022-07-13T20:32:31Z

You can preview 5a47792 at https://pr46685-5a47792.ngbuilds.io/.

AndrewKushnir · 2022-07-13T22:37:12Z

Presubmit #2.

packages/core/src/render3/component.ts

alxhub

Reviewed-for: public-api

This commit introduces a new function that allows creating a `ComponentRef` instance based on provided Component and a set of options. The function can be used to cover a number of use-cases where the `ComponentFactory` symbol was used previously. Closes angular#45263.

This commit introduces a new function that allows creating a object which exposes a number of getters to retrieve information about a given component. Closes angular#44926.

This commit refactors the code to move some functions around to avoid circular dependencies in TS imports. The newly added functions are now located in the `packages/core/src/render3/component.ts` file (instead of `packages/core/src/render3/component_ref.ts`), which is a better place for them anyway.

This commit updates the `inputs` and `outputs` objects of the `ComponentMirror` to mark their properties as readonly.

mary-poppins · 2022-07-14T18:26:42Z

You can preview cb82edc at https://pr46685-cb82edc.ngbuilds.io/.

jessicajaniuk · 2022-07-14T18:52:38Z

This PR was merged into the repository by commit 4a81fe7.

This commit introduces a new function that allows creating a object which exposes a number of getters to retrieve information about a given component. Closes #44926. PR Close #46685

This commit refactors the code to move some functions around to avoid circular dependencies in TS imports. The newly added functions are now located in the `packages/core/src/render3/component.ts` file (instead of `packages/core/src/render3/component_ref.ts`), which is a better place for them anyway. PR Close #46685

…46685) This commit updates the `inputs` and `outputs` objects of the `ComponentMirror` to mark their properties as readonly. PR Close #46685

angular-automatic-lock-bot · 2022-08-14T16:06:11Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

AndrewKushnir added feature Label used to distinguish feature request from other issues state: WIP area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release labels Jul 2, 2022

ngbot bot modified the milestone: Backlog Jul 2, 2022

pkozlowski-opensource mentioned this pull request Jul 4, 2022

Alternative way for depreciation of ComponentFactory in order to get componentFactory inputs #44926

Closed

AndrewKushnir force-pushed the create-component-ref branch 2 times, most recently from 460d222 to 274f4a3 Compare July 8, 2022 01:45

AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Jul 8, 2022

AndrewKushnir requested review from alxhub, atscott and pkozlowski-opensource and removed request for alxhub July 8, 2022 01:49

AndrewKushnir marked this pull request as ready for review July 8, 2022 01:49

AndrewKushnir changed the title ~~feat(core): add createComponentRef and createComponentMirror functions~~ feat(core): add createComponentRef and reflectComponentType functions Jul 8, 2022

pkozlowski-opensource mentioned this pull request Jul 8, 2022

Cannot create component without inserting into DOM without the deprecated ComponentFactory #45263

Closed

pkozlowski-opensource reviewed Jul 8, 2022

View reviewed changes

packages/core/src/render3/component_ref.ts Outdated Show resolved Hide resolved

pullapprove bot requested a review from dylhunn July 8, 2022 06:27

pkozlowski-opensource reviewed Jul 8, 2022

View reviewed changes

packages/core/src/render3/component_ref.ts Outdated Show resolved Hide resolved

pkozlowski-opensource reviewed Jul 8, 2022

View reviewed changes

packages/core/src/render3/component_ref.ts Outdated Show resolved Hide resolved

pkozlowski-opensource reviewed Jul 8, 2022

View reviewed changes

packages/core/src/render3/errors.ts Outdated Show resolved Hide resolved

pkozlowski-opensource requested changes Jul 8, 2022

View reviewed changes

atscott approved these changes Jul 8, 2022

View reviewed changes

packages/core/src/render3/component_ref.ts Outdated Show resolved Hide resolved

dylhunn removed their request for review July 13, 2022 18:28

AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 13, 2022

alxhub reviewed Jul 13, 2022

View reviewed changes

goldens/public-api/core/index.md Outdated Show resolved Hide resolved

packages/core/src/render3/component.ts Outdated Show resolved Hide resolved

packages/core/src/render3/component_ref.ts Outdated Show resolved Hide resolved

AndrewKushnir force-pushed the create-component-ref branch from f1af445 to 5a47792 Compare July 13, 2022 20:24

AndrewKushnir requested a review from alxhub July 13, 2022 20:26

alxhub reviewed Jul 14, 2022

View reviewed changes

packages/core/src/render3/component.ts Outdated Show resolved Hide resolved

alxhub approved these changes Jul 14, 2022

View reviewed changes

AndrewKushnir added 4 commits July 14, 2022 11:11

feat(core): add reflectComponentType function

d3ed98c

This commit introduces a new function that allows creating a object which exposes a number of getters to retrieve information about a given component. Closes angular#44926.

refactor(core): annotate ComponentMirror object fields as readonly

cb82edc

This commit updates the `inputs` and `outputs` objects of the `ComponentMirror` to mark their properties as readonly.

AndrewKushnir force-pushed the create-component-ref branch from 5a47792 to cb82edc Compare July 14, 2022 18:18

AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Jul 14, 2022

jessicajaniuk closed this in d1e83e1 Jul 14, 2022

AndrewKushnir mentioned this pull request Jul 15, 2022

[14.1.x] feat(core): add createComponent and reflectComponentType functions #46856

Merged

angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 14, 2022

Conversation

AndrewKushnir commented Jul 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Does this PR introduce a breaking change?

Uh oh!

gund commented Jul 4, 2022

Uh oh!

AndrewKushnir commented Jul 8, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pkozlowski-opensource left a comment

Choose a reason for hiding this comment

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir commented Jul 13, 2022

Uh oh!

mary-poppins commented Jul 13, 2022

Uh oh!

AndrewKushnir commented Jul 13, 2022

Uh oh!

Uh oh!

alxhub left a comment

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Jul 14, 2022

Uh oh!

jessicajaniuk commented Jul 14, 2022

Uh oh!

angular-automatic-lock-bot bot commented Aug 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

AndrewKushnir commented Jul 2, 2022 •

edited

Loading