fix(localize): add --project option to ng-add schematic#46664
Closed
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Closed
fix(localize): add --project option to ng-add schematic#46664alan-agius4 wants to merge 2 commits intoangular:mainfrom
--project option to ng-add schematic#46664alan-agius4 wants to merge 2 commits intoangular:mainfrom
Conversation
alan-agius4
commented
Jul 1, 2022
`--project` is unwritten standard to provide the project name. With this change we allow the project name to be provided using the `--project` command line argument and remove the ambiguity with other schematics.
d93a7e7 to
023a9c2
Compare
--project option to ng-add schematic--project option to ng-add schematic
AndrewKushnir
approved these changes
Jul 1, 2022
Contributor
|
One quick question: should we log a message/warning when the |
Contributor
Author
Instead of an alias, I deprecated the option. When used the CLI will issue a deprecation warning. |
4c057b1 to
b33bc02
Compare
b33bc02 to
d2a732f
Compare
d2a732f to
6dd4c36
Compare
Member
|
This PR was merged into the repository by commit 392c567. |
alxhub
pushed a commit
that referenced
this pull request
Jul 6, 2022
`--project` is unwritten standard to provide the project name. With this change we allow the project name to be provided using the `--project` command line argument and remove the ambiguity with other schematics. PR Close #46664
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jul 18, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.5/14.0.6) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.5/14.0.6) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.5/14.0.6) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.5/14.0.6) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.5/14.0.6) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.5/14.0.6) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.5/14.0.6) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.5/14.0.6) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.0.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1406-2022-07-13) [Compare Source](angular/angular@14.0.5...14.0.6) ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [99697dae66](angular/angular@99697da) | fix | only consider used pipes for inline type-check requirement ([#​46807](angular/angular#46807)) | ##### forms | Commit | Type | Description | | -- | -- | -- | | [4f469cbef3](angular/angular@4f469cb) | fix | expose ControlConfig in public API ([#​46594](angular/angular#46594)) | | [e8c8b695f2](angular/angular@e8c8b69) | fix | Move all remaining errors in Forms to use RuntimeErrorCode. ([#​46654](angular/angular#46654)) | ##### localize | Commit | Type | Description | | -- | -- | -- | | [14863acb1a](angular/angular@14863ac) | fix | add `--project` option to `ng-add` schematic ([#​46664](angular/angular#46664)) | #### Special Thanks Alan Agius, Andrew Scott, Bob Watson, Dylan Hunn, George Kalpakas, Ivaylo Kirov, Jessica Janiuk, JoostK, Joshua VanAllen, Lukas Matta, Marcin Wosinek, Nicolas Molina Monroy, Paul Gschwendtner, SoulsMark, Uday Sony, dario-piotrowicz, markostanimirovic and zhysky <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjMyLjExMS4xIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1459 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--projectis unwritten standard to provide the project name. With this change we allow the project name to be provided using the--projectcommand line argument and remove the ambiguity with other schematics.