renderComponent cleanup for integration tests.#46568
Closed
alxhub wants to merge 3 commits intoangular:mainfrom
Closed
renderComponent cleanup for integration tests.#46568alxhub wants to merge 3 commits intoangular:mainfrom
alxhub wants to merge 3 commits intoangular:mainfrom
Conversation
The ngcc integration test application doesn't actually run, but was coded to use the experimental `renderComponent` bootstrapping function. This commit switches it to use the regular, `@angular/platform-browser` based bootstrap instead.
This commit removes an integration test for an application, built with the CLI, that uses the `renderComponent` experimental bootstrapping function. An equivalent test already exists for the regular bootstrapping code path. As `renderComponent` is no longer supported, this test is redundant and can be removed.
This commit removes 2 benchmarks which are using the `renderComponent` and `Renderer3` abstractions, both of which are experimental and unsupported. Equivalent benchmarks exist for the real rendering code path.
Contributor
|
Only failure seems to be a flake. |
Contributor
|
This PR was merged into the repository by commit aac5344. |
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
…6568) This commit removes an integration test for an application, built with the CLI, that uses the `renderComponent` experimental bootstrapping function. An equivalent test already exists for the regular bootstrapping code path. As `renderComponent` is no longer supported, this test is redundant and can be removed. PR Close #46568
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
This commit removes 2 benchmarks which are using the `renderComponent` and `Renderer3` abstractions, both of which are experimental and unsupported. Equivalent benchmarks exist for the real rendering code path. PR Close #46568
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
The ngcc integration test application doesn't actually run, but was coded to use the experimental `renderComponent` bootstrapping function. This commit switches it to use the regular, `@angular/platform-browser` based bootstrap instead. PR Close #46568
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
…6568) This commit removes an integration test for an application, built with the CLI, that uses the `renderComponent` experimental bootstrapping function. An equivalent test already exists for the regular bootstrapping code path. As `renderComponent` is no longer supported, this test is redundant and can be removed. PR Close #46568
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
This commit removes 2 benchmarks which are using the `renderComponent` and `Renderer3` abstractions, both of which are experimental and unsupported. Equivalent benchmarks exist for the real rendering code path. PR Close #46568
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details.