refactor(core): disable renderer3 unless explicitly enabled by tests#46530
Closed
alxhub wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): disable renderer3 unless explicitly enabled by tests#46530alxhub wants to merge 1 commit intoangular:mainfrom
alxhub wants to merge 1 commit intoangular:mainfrom
Conversation
The `Renderer3` abstraction in Angular was an experimental code path in Ivy which uses direct DOM operations instead of the former `Renderer2` path. To allow `Renderer2` to tree-shake away, `Renderer3` is the default _unless_ `Renderer2` is provided. It was only an experiment, and never meant to be a production code path. However, it's possible for `Renderer3` to leak into user code. This commit prevents that possibility by causing the `Renderer3` path to throw, unless an explicit function has been called to enable it.
38816f4 to
5040d2a
Compare
Member
Author
Contributor
|
This PR was merged into the repository by commit a322b7d. |
dylhunn
pushed a commit
that referenced
this pull request
Jun 28, 2022
…46530) The `Renderer3` abstraction in Angular was an experimental code path in Ivy which uses direct DOM operations instead of the former `Renderer2` path. To allow `Renderer2` to tree-shake away, `Renderer3` is the default _unless_ `Renderer2` is provided. It was only an experiment, and never meant to be a production code path. However, it's possible for `Renderer3` to leak into user code. This commit prevents that possibility by causing the `Renderer3` path to throw, unless an explicit function has been called to enable it. PR Close #46530
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Renderer3abstraction in Angular was an experimental code path in Ivywhich uses direct DOM operations instead of the former
Renderer2path. Toallow
Renderer2to tree-shake away,Renderer3is the default unlessRenderer2is provided. It was only an experiment, and never meant to be aproduction code path.
However, it's possible for
Renderer3to leak into user code. This commitprevents that possibility by causing the
Renderer3path to throw, unlessan explicit function has been called to enable it.