feat(common): add cloudflare loader#46315
feat(common): add cloudflare loader#46315khempenius wants to merge 1 commit intoangular:image-directivefrom
Conversation
| throw new RuntimeError( | ||
| RuntimeErrorCode.INVALID_INPUT, | ||
| `ImgixLoader has detected an invalid path: ` + | ||
| `expecting a path like https://somepath.imgix.net/` + |
There was a problem hiding this comment.
I guess this shouldn't reference Imgix
There was a problem hiding this comment.
Good catch, thnx @intellix - I'm going to merge it as-is and send a follow-up PR since I'm planing to do a couple of cleanup moves anyway.
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM overall. This PR needs some cleanup (git conflict, error message, duplicated utils usage) so I'm going to re-base it, cleanup things and push to the image-directive branch.
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM overall. This PR needs some cleanup (git conflict, error message, duplicated utils usage) so I'm going to re-base it, cleanup things and push to the image-directive branch.
|
Merged as 40ea24a |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Pushing up as a placeholder. Will need to update to reflect #46277.
Does this PR introduce a breaking change?