feat(common): add loaders for Cloudinary and ImageKit providers#46277
Merged
pkozlowski-opensource merged 3 commits intoangular:image-directivefrom Jun 9, 2022
Merged
Conversation
dab8867 to
5bcbdcd
Compare
pkozlowski-opensource
requested changes
Jun 7, 2022
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
The change LGTM overall but we start to have code duplication between various loaders and I would love to see the common logic extracted before this PR gets merged.
packages/common/src/directives/ng_optimized_image/image_loaders/cloudinary_loader.ts
Outdated
Show resolved
Hide resolved
packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts
Outdated
Show resolved
Hide resolved
5bcbdcd to
4dc26b4
Compare
kara
approved these changes
Jun 7, 2022
packages/common/src/directives/ng_optimized_image/image_loaders/cloudinary_loader.ts
Outdated
Show resolved
Hide resolved
packages/common/src/directives/ng_optimized_image/image_loaders/imagekit_loader.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Nit: path error seems like it can be shared if the name of the loader is also passed as an arg
Contributor
Author
There was a problem hiding this comment.
I wrote slightly different error messages for the Cloudinary & Imgix loaders (which is why I didn't move more of this into loader_utils). I considered passing the whole error message as an argument but that felt awkward IMO.
4dc26b4 to
ea0076e
Compare
This commit adds loaders for cloudinary and imagekit.
…e ensurePreconnect option This commit modifies the provideCloudinaryLoader and provideImageKitLoader functions to support an additional ensurePreconnect option, similar to the Imgix loader functions.
ea0076e to
ba630fb
Compare
This commit refactors the code to avoid an extra utils file and instead, all extra helpers are moved to a common location.
ba630fb to
80637b4
Compare
2 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?