fix(core): handle AOT-compiled standalone components in TestBed correctly#46052
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): handle AOT-compiled standalone components in TestBed correctly#46052AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
…ctly Previously, the code in TestBed didn't take into account the fact that the `cmp.dependencies` array after the AOT compilation might contain regular (NgModule-based) Components/Directive/Pipes. As a result, some NgModule-specific code paths were invoked for non-NgModule types, thus leading to errors. This commit updates the code to handle AOT-compiled structure of standalone components correctly.
Contributor
Author
alxhub
reviewed
May 19, 2022
| const def = getComponentDef(value); | ||
| queueTypesFromModulesArrayRecur(maybeUnwrapFn(def.dependencies ?? [])); | ||
| const dependencies = maybeUnwrapFn(def.dependencies ?? []); | ||
| dependencies.forEach((dependency) => { |
alxhub
approved these changes
May 19, 2022
Contributor
Author
|
Thanks for the review @alxhub 👍 |
Member
|
This PR was merged into the repository by commit dfba192. |
alxhub
pushed a commit
that referenced
this pull request
May 23, 2022
…ctly (#46052) Previously, the code in TestBed didn't take into account the fact that the `cmp.dependencies` array after the AOT compilation might contain regular (NgModule-based) Components/Directive/Pipes. As a result, some NgModule-specific code paths were invoked for non-NgModule types, thus leading to errors. This commit updates the code to handle AOT-compiled structure of standalone components correctly. PR Close #46052
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the code in TestBed didn't take into account the fact that the
cmp.dependenciesarray after the AOT compilation might contain regular (NgModule-based) Components/Directive/Pipes. As a result, some NgModule-specific code paths were invoked for non-NgModule types, thus leading to errors.This commit updates the code to handle AOT-compiled structure of standalone components correctly.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?