Skip to content

fix(language-service): Fix detection of Angular for v14+ projects#45998

Closed
ivanwonder wants to merge 1 commit intoangular:mainfrom
ivanwonder:fix-detection-of-angular-14
Closed

fix(language-service): Fix detection of Angular for v14+ projects#45998
ivanwonder wants to merge 1 commit intoangular:mainfrom
ivanwonder:fix-detection-of-angular-14

Conversation

@ivanwonder
Copy link
Contributor

@ivanwonder ivanwonder commented May 14, 2022

In v14, the .d.ts file for angular core is now "index.d.ts" rather than "core.d.ts".

This change happened in ng-packagr/ng-packagr@c6f6e4d

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

In v14, the .d.ts file for angular core is now "index.d.ts" rather than "core.d.ts".

This change happened in ng-packagr/ng-packagr@c6f6e4d
@pullapprove pullapprove bot requested a review from atscott May 14, 2022 12:08
@pkozlowski-opensource pkozlowski-opensource added the area: language-service Issues related to Angular's VS Code language service label May 16, 2022
@ngbot ngbot bot added this to the Backlog milestone May 16, 2022
@atscott atscott added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels May 16, 2022
@jessicajaniuk
Copy link
Contributor

@ivanwonder @atscott This PR has conflicts with 13.3.x. Updating to target: rc. Please create a patch PR.

@jessicajaniuk jessicajaniuk added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 16, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit db1b6fe.

jessicajaniuk pushed a commit that referenced this pull request May 16, 2022
…5998)

In v14, the .d.ts file for angular core is now "index.d.ts" rather than "core.d.ts".

This change happened in ng-packagr/ng-packagr@c6f6e4d

PR Close #45998
@ivanwonder ivanwonder deleted the fix-detection-of-angular-14 branch May 17, 2022 02:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants