Skip to content

[13.3] perf(core): allow checkNoChanges mode to be tree-shaken in production#45936

Closed
JoostK wants to merge 1 commit intoangular:13.3.xfrom
JoostK:devmode-checknochanges-13
Closed

[13.3] perf(core): allow checkNoChanges mode to be tree-shaken in production#45936
JoostK wants to merge 1 commit intoangular:13.3.xfrom
JoostK:devmode-checknochanges-13

Conversation

@JoostK
Copy link
Member

@JoostK JoostK commented May 9, 2022

Cherry-pick of #45913 for 13.3.x branch

This commit guards all logic that exists for the `checkNoChanges` mode
with `ngDevMode` checks such that the logic can be tree-shaken.
@JoostK JoostK added area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release PullApprove: disable labels May 9, 2022
@ngbot ngbot bot added this to the Backlog milestone May 9, 2022
@JoostK JoostK marked this pull request as ready for review May 9, 2022 20:13
@JoostK JoostK added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels May 9, 2022
@JoostK
Copy link
Member Author

JoostK commented May 9, 2022

caretaker note: this is a cherry-pick PR for #45913; no presubmit needed and already approved.

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 73bbee2.

AndrewKushnir pushed a commit that referenced this pull request May 9, 2022
…on (#45936)

This commit guards all logic that exists for the `checkNoChanges` mode
with `ngDevMode` checks such that the logic can be tree-shaken.

PR Close #45936
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request May 13, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.3.6` -> `13.3.7`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.3.6/13.3.7) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.3.6` -> `13.3.7`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.3.6/13.3.7) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.3.6` -> `13.3.7`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.3.6/13.3.7) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.3.6` -> `13.3.7`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.3.6/13.3.7) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.3.6` -> `13.3.7`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.3.6/13.3.7) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.3.6` -> `13.3.7`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.3.6/13.3.7) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.3.6` -> `13.3.7`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.3.6/13.3.7) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.3.6` -> `13.3.7`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.3.6/13.3.7) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v13.3.7`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1337-2022-05-11)

[Compare Source](angular/angular@13.3.6...13.3.7)

##### core

| Commit | Type | Description |
| -- | -- | -- |
| [73bbee2c0d](angular/angular@73bbee2) | perf | allow `checkNoChanges` mode to be tree-shaken in production ([#&#8203;45936](angular/angular#45936)) |

##### language-service

| Commit | Type | Description |
| -- | -- | -- |
| [5ca3bcf4f8](angular/angular@5ca3bcf) | fix | Add resource files as roots to their associated projects ([#&#8203;45601](angular/angular#45601)) |

#### Special Thanks

Andrew Kushnir, Andrew Scott, George Kalpakas, JayMartMedia, JoostK, Paul Gschwendtner, Ted.chang, Thomas Mair, Will 保哥, dario-piotrowicz, mgechev and ᚷᛁᛟᚱᚷᛁ ᛒᚨᛚᚨᚲᚻᚨᛞᛉᛖ

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1348
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants