Skip to content

fix(compiler-cli): update unknown tag error for aot standalone components#45919

Closed
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:unknown-tag-in-standalone-component-aot
Closed

fix(compiler-cli): update unknown tag error for aot standalone components#45919
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:unknown-tag-in-standalone-component-aot

Conversation

@dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented May 8, 2022 •
edited
Loading

update the error message presented during aot compilation when an unrecognized
tag/element is found in a standalone component so that it does not mention
the ngModule anymore

Note: the jit variant is present in PR #45920

resolves #45818

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (or bugfix maybe)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Issue

Issue Number: #45818

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Result:
AOT

@dario-piotrowicz dario-piotrowicz mentioned this pull request May 8, 2022
Closed
14 tasks
@dario-piotrowicz dario-piotrowicz force-pushed the unknown-tag-in-standalone-component-aot branch from d6307cc to 8a50e60 Compare May 8, 2022 08:59
@dario-piotrowicz dario-piotrowicz changed the title feat(compiler-cli): update unknown tag in aot standalone component feat(compiler-cli): update unknown tag error for aot standalone components May 8, 2022
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review May 8, 2022 09:05
@pullapprove pullapprove bot requested a review from alxhub May 8, 2022 09:05
@dario-piotrowicz dario-piotrowicz force-pushed the unknown-tag-in-standalone-component-aot branch from 8a50e60 to 108a017 Compare May 8, 2022 09:14
@pkozlowski-opensource pkozlowski-opensource added area: compiler Issues related to `ngc`, Angular's template compiler cross-cutting: standalone Issues related to the NgModule-less world labels May 9, 2022
@ngbot ngbot bot added this to the Backlog milestone May 9, 2022
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 10, 2022
@antl3x antl3x mentioned this pull request May 13, 2022
Closed
@dario-piotrowicz dario-piotrowicz force-pushed the unknown-tag-in-standalone-component-aot branch from 108a017 to 77f41b9 Compare May 14, 2022 13:49
@dario-piotrowicz dario-piotrowicz changed the title feat(compiler-cli): update unknown tag error for aot standalone components fix(compiler-cli): update unknown tag error for aot standalone components May 14, 2022
dario-piotrowicz added a commit to dario-piotrowicz/angular that referenced this pull request May 18, 2022
@dario-piotrowicz
fix(core): update unknown tag error for jit standalone components
ce32127 
update the error message presented during jit compilation when an unrecognized
tag/element is found in a standalone component so that it does not mention
the ngModule anymore

Note: the aot variant is present in PR angular#45919

resolves angular#45818
JoostK
JoostK approved these changes May 20, 2022
View reviewed changes
@JoostK JoostK added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 20, 2022
@dario-piotrowicz dario-piotrowicz force-pushed the unknown-tag-in-standalone-component-aot branch from 77f41b9 to b6b06e7 Compare May 20, 2022 21:34
@JoostK JoostK removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 20, 2022
@JoostK JoostK added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit labels May 20, 2022
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented May 21, 2022

Presubmit.

@dario-piotrowicz @AndrewKushnir
fix(compiler-cli): update unknown tag error for aot standalone compon…
2e6f18a 
…ents

update the error message presented during aot compilation when an unrecognized
tag/element is found in a standalone component so that it does not mention
the ngModule anymore

Note: the jit variant is present in PR angular#45920

resolves angular#45818
@AndrewKushnir AndrewKushnir force-pushed the unknown-tag-in-standalone-component-aot branch from b6b06e7 to 2e6f18a Compare May 21, 2022 01:56
@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label May 21, 2022
alxhub pushed a commit that referenced this pull request May 23, 2022
@dario-piotrowicz @alxhub
fix(core): update unknown tag error for jit standalone components (#4…
df339d8 
…5920)

update the error message presented during jit compilation when an unrecognized
tag/element is found in a standalone component so that it does not mention
the ngModule anymore

Note: the aot variant is present in PR #45919

resolves #45818

PR Close #45920
alxhub pushed a commit that referenced this pull request May 23, 2022
@dario-piotrowicz @alxhub
fix(core): update unknown tag error for jit standalone components (#4…
b1a4b30 
…5920)

update the error message presented during jit compilation when an unrecognized
tag/element is found in a standalone component so that it does not mention
the ngModule anymore

Note: the aot variant is present in PR #45919

resolves #45818

PR Close #45920
@jessicajaniuk jessicajaniuk removed the request for review from alxhub May 23, 2022 16:48
@alxhub
Copy link
Member

alxhub commented May 23, 2022

This PR was merged into the repository by commit 18b0ee0.

alxhub pushed a commit that referenced this pull request May 23, 2022
@dario-piotrowicz @alxhub
fix(compiler-cli): update unknown tag error for aot standalone compon…
f2e5234 
…ents (#45919)

update the error message presented during aot compilation when an unrecognized
tag/element is found in a standalone component so that it does not mention
the ngModule anymore

Note: the jit variant is present in PR #45920

resolves #45818

PR Close #45919
@alxhub alxhub closed this in 18b0ee0 May 23, 2022
@AndrewKushnir AndrewKushnir mentioned this pull request May 26, 2022
Closed
3 tasks
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 1, 2022
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 23, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK approved these changes

Assignees

@alxhub alxhub

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cross-cutting: standalone Issues related to the NgModule-less world target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

v14-candidates

Development

Successfully merging this pull request may close these issues.

Update error message for an unknown tag in standalone components

5 participants

@dario-piotrowicz @AndrewKushnir @alxhub @JoostK @pkozlowski-opensource