ci: update the list of excluded paths in NgBot config#45901
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
ci: update the list of excluded paths in NgBot config#45901AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
This commit aligns the NgBot config that is used to determine whether a presubmit is needed with its internal version.
AndrewKushnir
commented
May 5, 2022
| - 'packages/bazel/src/api-extractor/**' | ||
| - 'packages/bazel/src/builders/**' | ||
| - 'packages/bazel/src/ng_package/**' | ||
| - 'packages/bazel/src/ng_module/**' |
Contributor
Author
There was a problem hiding this comment.
Note to the reviewers: this is a bit unexpected: we were syncing the code from this path, but the presubmit was not required (the path was excluded)...
Member
There was a problem hiding this comment.
Ahh interesting, I think we chatted about this and this rule is no longer used internally, so potentially we can stop syncing
Contributor
Author
|
This PR was merged into the repository by commit 3e7d299. |
AndrewKushnir
added a commit
that referenced
this pull request
May 5, 2022
This commit aligns the NgBot config that is used to determine whether a presubmit is needed with its internal version. PR Close #45901
AndrewKushnir
added a commit
that referenced
this pull request
May 5, 2022
This commit aligns the NgBot config that is used to determine whether a presubmit is needed with its internal version. PR Close #45901
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit aligns the NgBot config that is used to determine whether a presubmit is needed with its internal version.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?