Aio home a11y improvements#45740
Conversation
aio/content/marketing/index.html
Outdated
aio/content/marketing/index.html
Outdated
There was a problem hiding this comment.
For this and the rest of the images, I think these are clearly decorative images so I think they should have an empty alt value (https://www.w3.org/WAI/tutorials/images/decorative/)
currently the aio home page presents a single h1 which is ignored by assistive technologies since it has its display set none, so replace it with a new h1 containing the main text of the page instead
convert the `div` groups in the aio home page to proper `section`s with a valid heading/title
in the aio home page the sections' decorative images provide an alt texts, which shouldn't actually be present (see: https://www.w3.org/WAI/tutorials/images/decorative/), empty such alt text for a better user experience
26561f8 to
5391fb5
Compare
|
@gkalpak I was about to create a single commit again, but I made sure to split it into 3 clear self contained commits, I hope that's fine 😃 (even though each commit is very very small) |
fix wrong title being set
|
You can preview 5391fb5 at https://pr45740-5391fb5.ngbuilds.io/. |
gkalpak
left a comment
There was a problem hiding this comment.
Nice work, @dario-piotrowicz 💯
Just a couple of minor comments.
I love the self-contained commits 😉
2e3edb4 to
e2754fb
Compare
refactor `!noTitle` to `needsTitle`
e2754fb to
594241c
Compare
|
You can preview 594241c at https://pr45740-594241c.ngbuilds.io/. |
|
This PR was merged into the repository by commit 7d8998c. |
convert the `div` groups in the aio home page to proper `section`s with a valid heading/title PR Close #45740
in the aio home page the sections' decorative images provide an alt texts, which shouldn't actually be present (see: https://www.w3.org/WAI/tutorials/images/decorative/), empty such alt text for a better user experience PR Close #45740
currently the aio home page presents a single h1 which is ignored by assistive technologies since it has its display set none, so replace it with a new h1 containing the main text of the page instead PR Close #45740
convert the `div` groups in the aio home page to proper `section`s with a valid heading/title PR Close #45740
in the aio home page the sections' decorative images provide an alt texts, which shouldn't actually be present (see: https://www.w3.org/WAI/tutorials/images/decorative/), empty such alt text for a better user experience PR Close #45740
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue
Issue Number: N/A
What is the new behavior?
Some simple a11y improvements in the aio home page
Does this PR introduce a breaking change?