refactor(core): make Testability compatible with tree-shaking#45657
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): make Testability compatible with tree-shaking#45657AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Testability compatible with tree-shaking#45657AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
f6aa6fa to
b9a5a8b
Compare
Contributor
Author
b9a5a8b to
fad9ebc
Compare
Testability compatible with tree-shaking
13c959e to
e72cbbb
Compare
jessicajaniuk
previously approved these changes
Apr 21, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM 🍪
reviewed-for: public-api
atscott
approved these changes
Apr 22, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
atscott
previously approved these changes
Apr 22, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: size-tracking
alxhub
approved these changes
May 5, 2022
atscott
previously approved these changes
May 5, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: size-tracking
9001f94
9001f94 to
195e3b1
Compare
This commit refactors the `Testability`-related logic to extract the necessary providers into a separate array, so that it can later become it's own NgModule (or exposed as an array of providers) and be excluded from the new APIs by default.
195e3b1 to
f931329
Compare
Contributor
Author
|
Note to the Caretaker (to myself 😄, but more for documentation purposes):
This PR is ready for merge. |
Contributor
Author
|
This PR was merged into the repository by commit c9b40b5. |
AndrewKushnir
added a commit
that referenced
this pull request
May 5, 2022
This commit refactors the `Testability`-related logic to extract the necessary providers into a separate array, so that it can later become it's own NgModule (or exposed as an array of providers) and be excluded from the new APIs by default. PR Close #45657
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
May 10, 2022
…otstrapApplication` The Testability-related logic was refactored in angular#45657 to become tree-shaking-friendly: it was decoupled from the core providers of the `BrowserModule`. This commit updates the newly-introduced `bootstrapApplication` function to exclude Testability-providers by default (note: the Testability is still included in the NgModule-based bootstrap). In order to add the Testability to the app bootstrapped via `bootstrapApplication`, the `provideProtractorTestingSupport` function is introduced.
AndrewKushnir
added a commit
that referenced
this pull request
May 10, 2022
…otstrapApplication` (#45885) The Testability-related logic was refactored in #45657 to become tree-shaking-friendly: it was decoupled from the core providers of the `BrowserModule`. This commit updates the newly-introduced `bootstrapApplication` function to exclude Testability-providers by default (note: the Testability is still included in the NgModule-based bootstrap). In order to add the Testability to the app bootstrapped via `bootstrapApplication`, the `provideProtractorTestingSupport` function is introduced. PR Close #45885
AndrewKushnir
added a commit
that referenced
this pull request
May 10, 2022
…otstrapApplication` (#45885) The Testability-related logic was refactored in #45657 to become tree-shaking-friendly: it was decoupled from the core providers of the `BrowserModule`. This commit updates the newly-introduced `bootstrapApplication` function to exclude Testability-providers by default (note: the Testability is still included in the NgModule-based bootstrap). In order to add the Testability to the app bootstrapped via `bootstrapApplication`, the `provideProtractorTestingSupport` function is introduced. PR Close #45885
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Testability-related logic to extract the necessary providers into a separate array, so that it can later become it's own NgModule (or exposed as an array of providers) and be excluded from the new APIs by default.