Skip to content

fix(compiler): scope css rules within @layer blocks#45396

Closed
JoostK wants to merge 1 commit intoangular:masterfrom
JoostK:css-layer
Closed

fix(compiler): scope css rules within @layer blocks#45396
JoostK wants to merge 1 commit intoangular:masterfrom
JoostK:css-layer

Conversation

@JoostK
Copy link
Member

@JoostK JoostK commented Mar 19, 2022

This commit starts scoping CSS rules nested within @layer blocks.

Fixes #45389

This commit starts scoping CSS rules nested within `@layer` blocks.

Fixes angular#45389
@JoostK JoostK added target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Mar 19, 2022
@ngbot ngbot bot added this to the Backlog milestone Mar 19, 2022
@JoostK JoostK marked this pull request as ready for review March 19, 2022 14:32
@JoostK JoostK added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 19, 2022
@JoostK JoostK requested a review from crisbeto March 19, 2022 16:29
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoostK JoostK added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 19, 2022
@crisbeto
Copy link
Member

Passing TGP.

@crisbeto crisbeto removed the action: presubmit The PR is in need of a google3 presubmit label Mar 21, 2022
@alxhub
Copy link
Member

alxhub commented Mar 21, 2022

This PR was merged into the repository by commit fffa023.

@alxhub alxhub closed this in fffa023 Mar 21, 2022
alxhub pushed a commit that referenced this pull request Mar 21, 2022
This commit starts scoping CSS rules nested within `@layer` blocks.

Fixes #45389

PR Close #45396
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 31, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.3.0/13.3.1) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.3.0/13.3.1) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.3.0/13.3.1) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.3.0/13.3.1) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.3.0/13.3.1) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.3.0/13.3.1) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.3.0/13.3.1) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.3.0` -> `13.3.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.3.0/13.3.1) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v13.3.1`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1331-2022-03-30)

[Compare Source](angular/angular@13.3.0...13.3.1)

##### bazel

| Commit | Type | Description |
| -- | -- | -- |
| [960e42b2ac](angular/angular@960e42b) | fix | ng module compilation workers are subject to linker race-conditions ([#&#8203;45393](angular/angular#45393)) |

##### compiler

| Commit | Type | Description |
| -- | -- | -- |
| [3714305f84](angular/angular@3714305) | fix | scope css rules within `@layer` blocks ([#&#8203;45396](angular/angular#45396)) |

##### compiler-cli

| Commit | Type | Description |
| -- | -- | -- |
| [7f53c0f4ac](angular/angular@7f53c0f) | fix | handle inline type-check blocks in nullish coalescing extended check ([#&#8203;45478](angular/angular#45478)) |

#### Special Thanks

AlirezaEbrahimkhani, Andrew Kushnir, Andrew Scott, Ben Brook, Dylan Hunn, George Kalpakas, JiaLiPassion, Joey Perrott, JoostK, Mike, Paul Gschwendtner, Willian Corrêa, arturovt, dario-piotrowicz, khai and mgechev

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1277
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View encapsulation breaks with new CSS Layers syntax

3 participants