feat(docs-infra): update CLI templates to match changes with new parser and folder structure#45225
Closed
alan-agius4 wants to merge 8 commits intoangular:masterfrom
alan-agius4:aio-cli-update
Closed
feat(docs-infra): update CLI templates to match changes with new parser and folder structure#45225alan-agius4 wants to merge 8 commits intoangular:masterfrom alan-agius4:aio-cli-update
alan-agius4 wants to merge 8 commits intoangular:masterfrom
alan-agius4:aio-cli-update
Conversation
Contributor
Author
|
CI will fail until we update the CLI SHA. Can I get a preemptive review? |
gkalpak
reviewed
Mar 4, 2022
Member
gkalpak
left a comment
There was a problem hiding this comment.
Preemptively looks reasonable 😃
aio/tools/transforms/cli-docs-package/processors/processCliCommands.js
Outdated
Show resolved
Hide resolved
…er and folder structure The underlying parser that the CLI uses changed which caused minor changes in the generated JSON helps especially for subcommands. The folder structure of the Angular CLI repo also changed slightly. More context: angular/angular-cli#22778
Hidden commands are no longer included in help JSON output.
…ew parser and folder structure
…ew parser and folder structure
Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).
…ew parser and folder structure
|
You can preview 70c7a46 at https://pr45225-70c7a46.ngbuilds.io/. |
…ew parser and folder structure
|
You can preview 34aedc3 at https://pr45225-34aedc3.ngbuilds.io/. |
Contributor
Author
|
@gkalpak and @josephperrott kindly take a look. |
gkalpak
approved these changes
Mar 10, 2022
Member
gkalpak
left a comment
There was a problem hiding this comment.
A couple of questions. Otherwise lgtm 👍
josephperrott
approved these changes
Mar 10, 2022
Member
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
We should definitely have @gkalpak review as well though as he has more historical context and understanding.
|
|
||
| doc.usages = generateUsages(doc); | ||
|
|
||
| // Recurse if there are subcommands |
Member
There was a problem hiding this comment.
So this only goes one level down correct, do we need to fully recurse further in?
Contributor
Author
There was a problem hiding this comment.
Not currently, since we only have 1 level subcommands in the Angular CLI
…ew parser and folder structure
|
You can preview 3a8da4e at https://pr45225-3a8da4e.ngbuilds.io/. |
Contributor
|
This PR was merged into the repository by commit 7f043c9. |
atscott
pushed a commit
that referenced
this pull request
Mar 10, 2022
Hidden commands are no longer included in help JSON output. PR Close #45225
atscott
pushed a commit
that referenced
this pull request
Mar 10, 2022
) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). PR Close #45225
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this pull request
Apr 8, 2022
…er and folder structure (angular#45225) The underlying parser that the CLI uses changed which caused minor changes in the generated JSON helps especially for subcommands. The folder structure of the Angular CLI repo also changed slightly. More context: angular/angular-cli#22778 PR Close angular#45225
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this pull request
Apr 8, 2022
Hidden commands are no longer included in help JSON output. PR Close angular#45225
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this pull request
Apr 8, 2022
…ular#45225) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). PR Close angular#45225
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying parser that the CLI uses changed which caused minor changes in the generated JSON helps especially for subcommands.
The folder structure of the Angular CLI repo also changed slightly.
More context: angular/angular-cli#22778