refactor(compiler-cli): update template typechecking link to latest angular.io version#44649
refactor(compiler-cli): update template typechecking link to latest angular.io version#44649dgp1130 wants to merge 1 commit intoangular:masterfrom
Conversation
…ngular.io version This page exists in the most recent angular.io version (v13 currently), so there's no need to link to an old version. The hash also refers to the title section of the page, which isn't necessary and is now dropped.
JoostK
left a comment
There was a problem hiding this comment.
FYI, I added this in #34195 (it was only moved in #34887) and I think the reason back then was that it required the v9 page, as the v8 docs did not have these flags.
One caveat with dropping the version is that the link is more likely to break in the future, where old versions of Angular would continue to link to a page that would no longer exist. But the same is true for
and I don't think it's a big problem.
|
@JoostK, I figured this might have originally been to "link into the future", though it seems like the PR landed after v9 (maybe it was drafted before that?). the proper solution would probably be to tie AIO links in error message to the version of Angular that the user is currently running. We could certainly do that, though it's a bit more effort than this one change. I made #44650 to follow up with a proper solution for error messages. |
It landed a bit before the v9 release; commit 2e82357 is from Jan 2020 whereas v9 was released in Feb 2020. I remember specifically because this was one of the last things on the list of releasing Ivy as stable 🙂 And yeah, capturing this in a separate issue makes sense, thanks for creating it. |
|
This PR was merged into the repository by commit de93b6e. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This page exists in the most recent angular.io version (v13 currently), so there's no need to link to an old version. The hash also refers to the title section of the page, which isn't necessary and is now dropped.
This was originally added in #34887, and doesn't appear to actually require the v9 version, so I don't see any reason not to update the link.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Error message links to old v9 documentation.
What is the new behavior?
Error message now links to the most current documentation.
Does this PR introduce a breaking change?
Other information
Identified in #44391 (comment), but pulled into its own PR to be more obvious about the change.