refactor(animations): add unit test for leaving animated child#44489
Closed
dario-piotrowicz wants to merge 1 commit intoangular:masterfrom
Closed
refactor(animations): add unit test for leaving animated child#44489dario-piotrowicz wants to merge 1 commit intoangular:masterfrom
dario-piotrowicz wants to merge 1 commit intoangular:masterfrom
Conversation
packages/core/test/animation/animation_query_integration_spec.ts
Outdated
Show resolved
Hide resolved
add a new unit test to make sure that leaving elements queried via a parent queried via animateChild are correctly removed note: this tests the fix introduced in PR angular#44357
42b1896 to
a438bc3
Compare
jessicajaniuk
approved these changes
Jan 4, 2022
packages/core/test/animation/animation_query_integration_spec.ts
Outdated
Show resolved
Hide resolved
Contributor
|
This PR was merged into the repository by commit f2b858d. |
dylhunn
pushed a commit
that referenced
this pull request
Jan 4, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a new unit test to make sure that leaving elements queried via
a parent queried via animateChild are correctly removed
note: this tests the fix introduced in PR #44357
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information