test(docs-infra): Correct an invalid assumption regarding FormControl in aio tests.#44479
Closed
dylhunn wants to merge 1 commit intoangular:masterfrom
Closed
test(docs-infra): Correct an invalid assumption regarding FormControl in aio tests.#44479dylhunn wants to merge 1 commit intoangular:masterfrom
FormControl in aio tests.#44479dylhunn wants to merge 1 commit intoangular:masterfrom
Conversation
14 tasks
FormControl in aio tests.FormControl in aio tests.
5fe23b6 to
be59d55
Compare
JoostK
reviewed
Dec 14, 2021
Contributor
|
@dylhunn FYI I've added the "cleanup" label based on the comment from Joost above. |
be59d55 to
aa48d3d
Compare
Contributor
Author
|
I have removed this test entirely, as Joost suggested above. |
JoostK
approved these changes
Dec 14, 2021
gkalpak
reviewed
Dec 14, 2021
Member
|
Sorry for the back and forth, @dylhunn, but I've added the |
The aio application expects `FormControl` to have no properties for the purposes of its own internal tests, but this is no longer true after angular#44434.
aa48d3d to
2f48e86
Compare
Contributor
Author
|
OK @gkalpak, I went ahead and added it back. |
gkalpak
approved these changes
Dec 14, 2021
Member
|
This PR was merged into the repository by commit 4aa6965. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aio application expects
FormControlto have no properties for the purposes of its own internal tests, but this is no longer true after #44434.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
a.io expects
FormControlwill have no properties as part of its own internal tests.Issue Number: N/A
What is the new behavior?
a.io uses
AsyncValidatorinstead, which actually has no properties.Does this PR introduce a breaking change?
Other information