Skip to content

perf(http): remove IE special status handling#44354

Closed
diicar wants to merge 1 commit intoangular:masterfrom
diicar:remove-ie9-related-status-workaround
Closed

perf(http): remove IE special status handling#44354
diicar wants to merge 1 commit intoangular:masterfrom
diicar:remove-ie9-related-status-workaround

Conversation

@diicar
Copy link
Contributor

@diicar diicar commented Dec 2, 2021

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Contains a workaround for IE

What is the new behavior?

Removed IE special Case handling

Does this PR introduce a breaking change?

  • Yes
  • No

@google-cla google-cla bot added the cla: no label Dec 2, 2021
@pullapprove pullapprove bot requested a review from dylhunn December 2, 2021 20:30
@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 2, 2021
@AndrewKushnir AndrewKushnir added area: common/http Issues related to HTTP and HTTP Client area: performance Issues related to performance labels Dec 2, 2021
@ngbot ngbot bot added this to the Backlog milestone Dec 2, 2021
@dylhunn
Copy link
Contributor

dylhunn commented Dec 3, 2021

It looks like CircleCI failed to run due to a rebase conflict. Can you rebase on master and push again?

Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Needs a rebase and fresh CI run)

@diicar
Copy link
Contributor Author

diicar commented Dec 3, 2021

conflicts are now resolved.
I updated the description by moving up because of ci/circleci: lint .
Can you please rerun ci/circleci: lint.
Thank you.

@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 7, 2022
@diicar diicar changed the title perf(http): remove IE special status handling and throw JSONP error o… perf(http): remove IE special status handling Jan 7, 2022
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 7, 2022
revert the condition as dev only
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Feb 3, 2022

Presubmit + Global Presubmit.

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 3, 2022
Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-http

@jessicajaniuk jessicajaniuk removed the request for review from alxhub February 4, 2022 18:57
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Feb 4, 2022
@AndrewKushnir
Copy link
Contributor

@dylhunn FYI the TGP is green, this PR is ready to go.

@dylhunn
Copy link
Contributor

dylhunn commented Feb 4, 2022

This PR was merged into the repository by commit 2839303.

dylhunn pushed a commit that referenced this pull request Feb 4, 2022
revert the condition as dev only

PR Close #44354
@dylhunn dylhunn closed this in 2839303 Feb 4, 2022
@diicar diicar deleted the remove-ie9-related-status-workaround branch February 4, 2022 20:24
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Feb 15, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.2.1/13.2.2) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.2.1/13.2.2) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.2.1/13.2.2) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.2.1/13.2.2) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.2.1/13.2.2) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.2.1/13.2.2) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.2.1/13.2.2) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.2.1/13.2.2) |
| [@angular/router](https://github.com/angular/angular) | dependencies | patch | [`13.2.1` -> `13.2.2`](https://renovatebot.com/diffs/npm/@angular%2frouter/13.2.1/13.2.2) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v13.2.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1322-2022-02-08)

[Compare Source](angular/angular@13.2.1...13.2.2)

##### compiler

| Commit | Type | Description |
| -- | -- | -- |
| [37af6abb49](angular/angular@37af6ab) | fix | allow banana-in-a-box bindings to end with non-null assertion ([#&#8203;37809](angular/angular#37809)) |

##### forms

| Commit | Type | Description |
| -- | -- | -- |
| [b75e90f809](angular/angular@b75e90f) | fix | incorrectly keeping track of ngModel with ngFor inside a form ([#&#8203;40459](angular/angular#40459)) |

##### http

| Commit | Type | Description |
| -- | -- | -- |
| [3fae6637e7](angular/angular@3fae663) | perf | remove IE special status handling ([#&#8203;44354](angular/angular#44354)) |

##### upgrade

| Commit | Type | Description |
| -- | -- | -- |
| [b9aab0c87b](angular/angular@b9aab0c) | fix | Do not trigger duplicate navigation events from Angular Router ([#&#8203;43441](angular/angular#43441)) |

#### Special Thanks

Alan Agius, Alan Cohen, Andrew Kushnir, Andrew Scott, Daniel Díaz, Dario Piotrowicz, Doug Parker, Jayson Acosta, Joey Perrott, JoostK, Kristiyan Kostadinov, Olivier Capuozzo, Ramzan, Shai Reznik, TANMAY SRIVASTAVA, dario-piotrowicz, iRealNirmal, jhonyeduardo, mgechev and zuckjet

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1160
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client area: performance Issues related to performance cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants