Remove VE code from language service package#44064
Closed
atscott wants to merge 2 commits intoangular:masterfrom
Closed
Remove VE code from language service package#44064atscott wants to merge 2 commits intoangular:masterfrom
atscott wants to merge 2 commits intoangular:masterfrom
Conversation
…vice package This commit removes ViewEngine-specific code from the langauge service package. This code is no longer used since VE is not supported in v13+.
…lder This commit moves code in the language service package out of the ivy subfolder. Ivy is the _only_ engine supported in v13+ so there's no need to have a name for it.
Contributor
Author
|
This PR was merged into the repository by commit 670cd10. |
Contributor
|
@atscott Will the removal of VE code have an effect on how the "Angular Language Service" VS Code extension works? Meaning when a new version of the extension is released with this change in it and my project is not using Angular v13, will it matter? |
Contributor
Author
|
@dzhavat For the Language Service extension in VSCode, we pull in the last version of |
Contributor
|
Thanks for the clarification. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two parts: