Skip to content

Conversation

@vsavkin
Copy link
Contributor

@vsavkin vsavkin commented Oct 1, 2014

Closes #38

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note on how function f({a=1, b=2}) {return a + b;} is transformed ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traceur parse trees do not end with ParseTree
I think it would benefit the maintainability to conform to Traceur naming spec

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this test? Only checking that we can add an empty object initializer, or that default values work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should call function with named params without passing any params by providing an empty object initializer

@vsavkin vsavkin merged this pull request into angular:master Oct 2, 2014
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
dalejodc pushed a commit to dalejodc/angular that referenced this pull request Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transpiler: handle named parameters

3 participants