refactor(core): delete some unused code#43884
Closed
alxhub wants to merge 3 commits intoangular:masterfrom
Closed
Conversation
Member
|
Heya, the View Engine tests appear to be failing! 🙃 |
c8de630 to
b0805ec
Compare
aafe8da to
7ccaa44
Compare
3 tasks
6037f2e to
8321aa6
Compare
ccad924 to
f71795c
Compare
Contributor
|
@google-cla I signed it! |
AndrewKushnir
approved these changes
Nov 19, 2021
e430b99 to
5cc50d2
Compare
This commit removes most tests that were designated as only covering View Engine code. It also removes tag filters from CI and local commands to run tests. In a few cases (such as with the packages/compiler tests), this tag was improperly applied, and certain test cases have been added back running in Ivy mode. This commit also empties `@angular/compiler/testing` as it is no longer necessary (this is safe since compiler packages are not public API). It can be deleted in the future.
This commit removes --config=viewengine and makes Ivy the default for building Angular.
This commit removes the View Engine runtime. Itself, this change is relatively straightforward, but it represents the final step in a multi-year journey. It's only possible due to the hard work of many current and former team members and collaborators, who are too numerous to list here. Co-authored-by: Alan Agius <alan.agius4@gmail.com> Co-authored-by: Andrew Kushnir <akushnir@google.com> Co-authored-by: Andrew Scott <atscott01@gmail.com> Co-authored-by: Andrew Seguin <andrewjs@google.com> Co-authored-by: Cédric Exbrayat <cedric@ninja-squad.com> Co-authored-by: Charles Lyding <19598772+clydin@users.noreply.github.com> Co-authored-by: Dave Shevitz <dshevitz@google.com> Co-authored-by: Doug Parker <dgp1130@users.noreply.github.com> Co-authored-by: Dylan Hunn <dylhunn@gmail.com> Co-authored-by: Emma Twersky <emmatwersky@google.com> Co-authored-by: George Kalpakas <kalpakas.g@gmail.com> Co-authored-by: Igor Minar <iminar@google.com> Co-authored-by: Jeremy Elbourn <jelbourn@google.com> Co-authored-by: Jessica Janiuk <jessicajaniuk@google.com> Co-authored-by: JiaLiPassion <JiaLi.Passion@gmail.com> Co-authored-by: Joey Perrott <josephperrott@gmail.com> Co-authored-by: Joost Koehoorn <joost.koehoorn@gmail.com> Co-authored-by: Kristiyan Kostadinov <crisbeto@abv.bg> Co-authored-by: Madleina Scheidegger <mscheid@google.com> Co-authored-by: Mark Thompson <2554588+MarkTechson@users.noreply.github.com> Co-authored-by: Minko Gechev <mgechev@gmail.com> Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com> Co-authored-by: Pawel Kozlowski <pkozlowski.opensource@gmail.com> Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> Co-authored-by: Wagner Maciel <wagnermaciel@google.com> Co-authored-by: Zach Arend <zachzach@google.com>
Member
Author
|
Caretaker: this requires a g3 patch update, as you know :) |
Contributor
|
This PR was merged into the repository by commit 8c71b9f. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 23, 2021
This commit removes --config=viewengine and makes Ivy the default for building Angular. PR Close #43884
jessicajaniuk
pushed a commit
that referenced
this pull request
Nov 23, 2021
This commit removes the View Engine runtime. Itself, this change is relatively straightforward, but it represents the final step in a multi-year journey. It's only possible due to the hard work of many current and former team members and collaborators, who are too numerous to list here. Co-authored-by: Alan Agius <alan.agius4@gmail.com> Co-authored-by: Andrew Kushnir <akushnir@google.com> Co-authored-by: Andrew Scott <atscott01@gmail.com> Co-authored-by: Andrew Seguin <andrewjs@google.com> Co-authored-by: Cédric Exbrayat <cedric@ninja-squad.com> Co-authored-by: Charles Lyding <19598772+clydin@users.noreply.github.com> Co-authored-by: Dave Shevitz <dshevitz@google.com> Co-authored-by: Doug Parker <dgp1130@users.noreply.github.com> Co-authored-by: Dylan Hunn <dylhunn@gmail.com> Co-authored-by: Emma Twersky <emmatwersky@google.com> Co-authored-by: George Kalpakas <kalpakas.g@gmail.com> Co-authored-by: Igor Minar <iminar@google.com> Co-authored-by: Jeremy Elbourn <jelbourn@google.com> Co-authored-by: Jessica Janiuk <jessicajaniuk@google.com> Co-authored-by: JiaLiPassion <JiaLi.Passion@gmail.com> Co-authored-by: Joey Perrott <josephperrott@gmail.com> Co-authored-by: Joost Koehoorn <joost.koehoorn@gmail.com> Co-authored-by: Kristiyan Kostadinov <crisbeto@abv.bg> Co-authored-by: Madleina Scheidegger <mscheid@google.com> Co-authored-by: Mark Thompson <2554588+MarkTechson@users.noreply.github.com> Co-authored-by: Minko Gechev <mgechev@gmail.com> Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com> Co-authored-by: Pawel Kozlowski <pkozlowski.opensource@gmail.com> Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com> Co-authored-by: Wagner Maciel <wagnermaciel@google.com> Co-authored-by: Zach Arend <zachzach@google.com> PR Close #43884
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing to see here, just some routine cleanup ;)