refactor(language-service): enable extended template diagnostics when strict templates is forced#43708
Closed
dgp1130 wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
Contributor
Author
|
We'll hold off on merging this until the feature is actually enabled in google3. |
b193382 to
e4d29f7
Compare
atscott
approved these changes
Oct 5, 2021
e4d29f7 to
3abaa0d
Compare
… strict templates is forced. This effectively enables extended template diagnostics in the VSCode extension in google3. This uses the existing `forceStrictTemplates` option to enable since that is already a prerequisite for extended template diagnostics and we don't distinguish between them at the configuration-level in google3 anyways.
3abaa0d to
4b14b54
Compare
Contributor
Author
|
google3 is ready, so we can merge this in whenever. The next release of the VSCode extension should include this change. |
Contributor
Author
|
Should be ready to merge to Note to caretaker, this is for google3 support so this does not need to be cherry-picked to v13. |
Contributor
|
This PR was merged into the repository by commit d151a3c. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively enables extended template diagnostics in the VSCode extension in google3. This uses the existing
forceStrictTemplatesoption to enable since that is already a prerequisite for extended template diagnostics and we don't distinguish between them at the configuration-level in google3 anyways.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: http://b/199443160
Extended template diagnostics are not shown in the VSCode extension for google3 applications.
What is the new behavior?
Extended template diagnostics are now shown in the VSCode extension for google3 applications.
Does this PR introduce a breaking change?
Other information
This is technically a feature, but only for google3 devs, so I left the commit as a
refactorjust so it doesn't show up in the public changelog and reduces noise.The package also seems to have existing test failures and I'm not sure how to properly use it in a test build of the extension, so I can't actually confirm that this does what I expect, however it's simple enough to be reasonably confident this works as intended.
/cc @alxhub