refactor(language-service): enable extended template diagnostics when strict templates is forced. (#43708)

dgp1130 · atscott · commit d151a3c375cc · 2021-10-12T17:45:50.000Z
This effectively enables extended template diagnostics in the VSCode extension in google3. This uses the existing `forceStrictTemplates` option to enable since that is already a prerequisite for extended template diagnostics and we don't distinguish between them at the configuration-level in google3 anyways. PR Close #43708
diff --git a/packages/language-service/ivy/language_service.ts b/packages/language-service/ivy/language_service.ts
@@ -501,6 +501,7 @@ function parseNgCompilerOptions(
   // regardless of its value in tsconfig.json.
   if (config.forceStrictTemplates === true) {
     options.strictTemplates = true;
+    options._extendedTemplateDiagnostics = true;
   }
 
   return options;
diff --git a/packages/language-service/ivy/test/legacy/language_service_spec.ts b/packages/language-service/ivy/test/legacy/language_service_spec.ts
@@ -82,6 +82,7 @@ describe('language service adapter', () => {
       // is enabled.
       expect(ngLS.getCompilerOptions()).toEqual(jasmine.objectContaining({
         strictTemplates: true,
+        _extendedTemplateDiagnostics: true,
       }));
     });
   });

Original file line number	Diff line number	Diff line change
`@@ -501,6 +501,7 @@ function parseNgCompilerOptions(`
`501`	`501`	`// regardless of its value in tsconfig.json.`
`502`	`502`	`if (config.forceStrictTemplates === true) {`
`503`	`503`	`options.strictTemplates = true;`
	`504`	`+ options._extendedTemplateDiagnostics = true;`
`504`	`505`	`}`
`505`	`506`
`506`	`507`	`return options;`