presubmit

Dunno if I should post here or in the Issues, but... After upgrading from v12.2.6 to v12.2.7 (with this fix included) my library project build now fails. Rolling only the compiler-cli package back to v12.2.6 is enough to solve the problem.

Last messages before build process fails are these:

× Compiling with Angular sources in Ivy partial compilation mode.
Unable to write a reference to <SomeInterface from another lib here>
   in <project_root>/node_modules/<some_lib_path>/<some-interface>.d.ts
   from <project root>/src/lib/<some_component_path>/<some-component>.component.ngtypecheck.ts

(SomeComponent extends another abstract component with Directive annotation on it, if this matters. Also SomeInterface not even remotely used in SomeComponent)

Any ideas?

@amariq that's a new bug, then. Please open a new issue with reproduction and I'll sort it out.

@JoostK uh oh, okay, I'll try, but I don't even know what could lead to that. Also it involves libraries (haven't tried to build an app, yet), and both of them are internal (one uses another).

@JoostK hello there :-)

I did some testing in our code (sorry, no issue/repro yet, will add later, still just digging up), and I think I found something.

The following part is the source of the issue:

// my-interface.ts
// this simple type
type MyValue<T, K extends keyof T = keyof T> = T | T[K];

// my-component.ts
// and type-checker fails on any other component, that uses MyComponent in its template
class MyComponent<T = any, V extends MyValue<T> = MyValue<T>> extends BaseComponent<T, V> {
  @Input()
  data: T[];

  @Input()
  value: V;
}

Any changes to MyValue don't do anything, and only removing it from MyComponent declaration or replacing with built-in types (V = any or V extends object = any) helps.

@amariq Could you share how MyValue is exported from my-interface.ts and how my-component.ts imports it?

@JoostK of course!

// my-interface.ts
// just simple export, no namespaces or anything, after build it changes to export declare type
export type MyValue = // ...

// my-component.ts
// also simple import
import { MyValue, <and some other symbols here> } from '../my/my-interface.ts';

I also tried changing import to import type, but no effect.

Thanks a lot. That seems simple enough and unfortunately does not yet give me any pointers as to why it started failing.

@JoostK some thoughts here.

At first I thought the reason is parameter constraints that depend on other parameters, but it doesn't seem to be the case.
I tried to edit d.ts files (assuming it would work) of the library that exports MyComponent in another library directly and changed parameters of MyComponent to replace MyValue with simpler MyValue2 = any, but it didn't help. I tried the following:

• MyComponent<T = any, V = MyValue2>
• MyComponent<T = any, V extends MyValue2 = any>
• MyComponent<T = any, V extends MyValue2 = MyValue2>
• MyComponent<T = any, V = MyValue2>
  But none worked.

Here is extended details on full type hierarchy (maybe it will bring some hints, its best I have time on right now):

• build of some library N fails because of using some components from library A, which in its turn uses some abstract component classes from library B)

• no namespaces used, but some places have import type

• export class MyComponent<T = any, V extends MyValue<T> = MyValue<T>> extends BaseComponent<T, V[]> (lib A)

  • export type MyValue<T, K extends FieldOf<T> = FieldOf<T>> = T | T[K] (imported from another file)
  • export type FieldOf<T> = keyof T & string (imported from lib B)

• export class BaseComponent<T, V extends ValueOrArray<MyValue<T>>> extends SuperBaseComponent<V> (lib A)

  • @Input() data: T[]
  • export type ValueOrArray<T> = T | T[] (imported from lib B)

• export class SuperBaseComponent<T> extends OneMoreComponent (lib A)

  • @Input() value: T

• export class OneMoreComponent (lib B)

@JoostK repro here! https://github.com/amariq/angular-pr43511-bug

Will post the issue later, if necessary :)

any news on this? We have the same issue after upgrading to v12.2.7

@amariq did you open an issue for this problem?

@kahmannf opened just now :)

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}