build(docs-infra): update @angular/* to 12.1.1#42776
Closed
gkalpak wants to merge 6 commits intoangular:masterfrom
Closed
build(docs-infra): update @angular/* to 12.1.1#42776gkalpak wants to merge 6 commits intoangular:masterfrom
gkalpak wants to merge 6 commits intoangular:masterfrom
Conversation
|
You can preview 26d915d at https://pr42776-26d915d.ngbuilds.io/. |
26d915d to
aa33ec5
Compare
gkalpak
commented
Jul 5, 2021
Member
Author
There was a problem hiding this comment.
FYI, from the ~2KB increase, ~0.5KB come from updating CLI/devkit and ~1.5KB from updating CDK.
|
You can preview aa33ec5 at https://pr42776-aa33ec5.ngbuilds.io/. |
|
You can preview 1f18575 at https://pr42776-1f18575.ngbuilds.io/. |
petebacondarwin
approved these changes
Jul 7, 2021
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
Typo in first commit: en eminent -> an imminent
Contributor
There was a problem hiding this comment.
This makes me a bit sad...
Contributor
There was a problem hiding this comment.
Another way to get around this would be to wrap the test code in a expect(() => {...}).not.toThrow()?
Member
Author
There was a problem hiding this comment.
Switched to .not.toThrow(). (Making you sad is the last thing I want from my PRs 😁)
petebacondarwin
approved these changes
Jul 7, 2021
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
Reviewed-for: size-tracking
This commit updates the payload sizes for angular.io to make it easier to identify payload size changes from an imminent update of `@angular/*` packages.
Update `@angular/*` packages to latest 12.1.x versions (mainly to take advantage of recent ServiceWorker improvements, such as angular#42607 and angular#42622).
Fix a unit test warning due to Jasmine not realizing that `httpMock.expectOne()` is an expectation. [Example][1]: > WARN: 'Spec 'DocumentService currentDocument should encode the request > path to be case-insensitive' has no expectations.' [1]: https://circleci.com/gh/angular/angular/1017640
….div()` This commit replaces the deprecated `/` operators used for division in Sass files with the [recommended][1] `math.div()` function to get rid of build warnings ([example][2]). [1]: https://sass-lang.com/documentation/breaking-changes/slash-div [2]: https://circleci.com/gh/angular/angular/1017640
This commit expands the info printed to the console to help diagnose ServiceWorker issues to include the [internal debug info][1] retrieved from `/ngsw/state`. This will provide more useful data, such as the activated SW's version, state, clients, recent operations and any recent errors. NOTE: This temporarily increases the payload size. Removing this code and reclaiming the payload size is being tracked in angular#41117. [1]: https://angular.io/guide/service-worker-devops#locating-and-analyzing-debugging-information
1f18575 to
52c54ce
Compare
|
You can preview 52c54ce at https://pr42776-52c54ce.ngbuilds.io/. |
petebacondarwin
approved these changes
Jul 7, 2021
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
Reviewed-for: size-tracking
atscott
approved these changes
Jul 7, 2021
Contributor
atscott
left a comment
There was a problem hiding this comment.
Reviewed-for: size-tracking
atscott
pushed a commit
that referenced
this pull request
Jul 7, 2021
This commit updates the payload sizes for angular.io to make it easier to identify payload size changes from an imminent update of `@angular/*` packages. PR Close #42776
atscott
pushed a commit
that referenced
this pull request
Jul 7, 2021
atscott
pushed a commit
that referenced
this pull request
Jul 7, 2021
Fix a unit test warning due to Jasmine not realizing that `httpMock.expectOne()` is an expectation. [Example][1]: > WARN: 'Spec 'DocumentService currentDocument should encode the request > path to be case-insensitive' has no expectations.' [1]: https://circleci.com/gh/angular/angular/1017640 PR Close #42776
atscott
pushed a commit
that referenced
this pull request
Jul 7, 2021
….div()` (#42776) This commit replaces the deprecated `/` operators used for division in Sass files with the [recommended][1] `math.div()` function to get rid of build warnings ([example][2]). [1]: https://sass-lang.com/documentation/breaking-changes/slash-div [2]: https://circleci.com/gh/angular/angular/1017640 PR Close #42776
atscott
pushed a commit
that referenced
this pull request
Jul 7, 2021
This commit expands the info printed to the console to help diagnose ServiceWorker issues to include the [internal debug info][1] retrieved from `/ngsw/state`. This will provide more useful data, such as the activated SW's version, state, clients, recent operations and any recent errors. NOTE: This temporarily increases the payload size. Removing this code and reclaiming the payload size is being tracked in #41117. [1]: https://angular.io/guide/service-worker-devops#locating-and-analyzing-debugging-information PR Close #42776
atscott
pushed a commit
that referenced
this pull request
Jul 7, 2021
atscott
pushed a commit
that referenced
this pull request
Jul 7, 2021
Fix a unit test warning due to Jasmine not realizing that `httpMock.expectOne()` is an expectation. [Example][1]: > WARN: 'Spec 'DocumentService currentDocument should encode the request > path to be case-insensitive' has no expectations.' [1]: https://circleci.com/gh/angular/angular/1017640 PR Close #42776
atscott
pushed a commit
that referenced
this pull request
Jul 7, 2021
….div()` (#42776) This commit replaces the deprecated `/` operators used for division in Sass files with the [recommended][1] `math.div()` function to get rid of build warnings ([example][2]). [1]: https://sass-lang.com/documentation/breaking-changes/slash-div [2]: https://circleci.com/gh/angular/angular/1017640 PR Close #42776
atscott
pushed a commit
that referenced
this pull request
Jul 7, 2021
This commit expands the info printed to the console to help diagnose ServiceWorker issues to include the [internal debug info][1] retrieved from `/ngsw/state`. This will provide more useful data, such as the activated SW's version, state, clients, recent operations and any recent errors. NOTE: This temporarily increases the payload size. Removing this code and reclaiming the payload size is being tracked in #41117. [1]: https://angular.io/guide/service-worker-devops#locating-and-analyzing-debugging-information PR Close #42776
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
@angular/*packages to latest 12.1.x versions (mainly to take advantage of recent ServiceWorker improvements, such as #42607 and #42622).