fix(platform-browser): prevent memory leak of style nodes if shadow D…#42005
Closed
JoostK wants to merge 1 commit intoangular:masterfrom
Closed
fix(platform-browser): prevent memory leak of style nodes if shadow D…#42005JoostK wants to merge 1 commit intoangular:masterfrom
JoostK wants to merge 1 commit intoangular:masterfrom
Conversation
…OM encapsulation is used Prior to this change, any inserted `<style>` nodes into shadow dom trees would be retained in memory, even after the shadow dom tree has been removed. This commit fixes the memory leak by tracking the inserted `<style>` nodes per host element, such that removal of the host element also releases the style nodes. Fixes angular#36655
crisbeto
reviewed
May 8, 2021
AndrewKushnir
approved these changes
May 9, 2021
Contributor
|
I've started a presubmit and will trigger a global run as well to make sure that there are no cases in g3 that may rely on the old behavior. Thank you. Update: I've started a global presubmit, will share the status once it's completed. |
Contributor
|
@JoostK FYI presubmits (including a global one) went well, so it looks like this PR is ready for merge (just needs the "merge" label) :) |
Member
Author
|
Say no more :-) |
alxhub
pushed a commit
that referenced
this pull request
May 10, 2021
…OM encapsulation is used (#42005) Prior to this change, any inserted `<style>` nodes into shadow dom trees would be retained in memory, even after the shadow dom tree has been removed. This commit fixes the memory leak by tracking the inserted `<style>` nodes per host element, such that removal of the host element also releases the style nodes. Fixes #36655 PR Close #42005
alxhub
pushed a commit
that referenced
this pull request
May 10, 2021
…OM encapsulation is used (#42005) Prior to this change, any inserted `<style>` nodes into shadow dom trees would be retained in memory, even after the shadow dom tree has been removed. This commit fixes the memory leak by tracking the inserted `<style>` nodes per host element, such that removal of the host element also releases the style nodes. Fixes #36655 PR Close #42005
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…OM encapsulation is used
Prior to this change, any inserted
<style>nodes into shadow dom trees would be retainedin memory, even after the shadow dom tree has been removed. This commit fixes the memory
leak by tracking the inserted
<style>nodes per host element, such that removal of thehost element also releases the style nodes.
Fixes #36655