test(forms): add integration test app to keep track of payload size#41045
Closed
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Closed
test(forms): add integration test app to keep track of payload size#41045AndrewKushnir wants to merge 1 commit intoangular:masterfrom
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
Author
|
Context: this is also needed to measure perf impact of the changes discussed in #41011. |
e7a153c to
9cf6f51
Compare
IgorMinar
approved these changes
Mar 5, 2021
Contributor
IgorMinar
left a comment
There was a problem hiding this comment.
two small nits, but otherwise LGTM. thanks!
Reviewed-for: size-tracking, integration-tests, dev-infra
This commit adds a Forms-based test app into the `integration` folder to have an ability to measure and keep track of payload size for the changes in Forms package.
9cf6f51 to
52d265c
Compare
jessicajaniuk
approved these changes
Mar 5, 2021
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM
reviewed-for: size-tracking
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a Forms-based test app into the
integrationfolder to have an ability to measure and keeptrack of payload size for the changes in Forms package.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?