Skip to content

Update to rulesnodejs@3.1.0#40710

Closed
josephperrott wants to merge 17 commits intoangular:masterfrom
josephperrott:update-rulesnodejs-3.1.0
Closed

Update to rulesnodejs@3.1.0#40710
josephperrott wants to merge 17 commits intoangular:masterfrom
josephperrott:update-rulesnodejs-3.1.0

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Feb 4, 2021 •
edited
Loading

See individual commits.

See rules_nodejs#stricter-ts-typechecks for more information on changes to castings involving JSON.parse

@josephperrott josephperrott added area: benchpress area: build & ci Related the build and CI infrastructure of the project area: testing Issues related to Angular testing features, such as TestBed action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n Issues related to localization and internationalization area: router area: zones Issues related to zone.js target: patch This PR is targeted for the next patch release area: bazel Issues related to the published `@angular/bazel` build rules area: service-worker Issues related to the @angular/service-worker package area: elements Issues related to Angular Elements comp: ts-api-guardian area: compiler Issues related to `ngc`, Angular's template compiler area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels Feb 4, 2021
@ngbot ngbot bot modified the milestone: Backlog Feb 4, 2021
@google-cla google-cla bot added the cla: yes label Feb 4, 2021
@josephperrott josephperrott marked this pull request as ready for review February 5, 2021 00:16
AndrewKushnir
AndrewKushnir reviewed Feb 5, 2021
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephperrott could you plz share a link (may be add to a PR description) to a change that triggered JSON.parse type cast (as an additional context for CR)?

@josephperrott josephperrott force-pushed the update-rulesnodejs-3.1.0 branch from 6776d17 to b675b26 Compare February 9, 2021 00:55
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 9, 2021
@josephperrott
Copy link
Member Author

josephperrott commented Feb 9, 2021

Caretaker Note: We should merge this and then watch the next few merges after to make sure there are not flakes.

@alxhub alxhub closed this in a6c1c91 Feb 9, 2021
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update integration test to use rules_nodejs@3.1.0 (#40710)
34de89a 
Update the integraiton tests for bazel to the latest rules_nodejs version.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
build: update tools directory for latest changes in rules_nodejs (#40710
b8b8535 
)

Update the scripts/tooling in the tools directory to handle the changes in the latest
version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(zone.js): update build tooling for latest changes in rules_nodejs (…
2827845 
…#40710)

Update the zone.js build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(service-worker): update type castings for JSON.parse usage (#40710)
4f7ff96 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(router): update type castings for JSON.parse usage (#40710)
350dada 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(platform-browser): update type castings for JSON.parse usage (#40710
7ecfd2d 
)

Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(localize): update type castings for JSON.parse usage (#40710)
4b469c9 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(elements): update type castings for JSON.parse usage (#40710)
efd4149 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler-cli): update type castings for JSON.parse usage (#40710)
b75d7cb 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler): update type castings for JSON.parse usage (#40710)
f728490 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(benchpress): update type castings for JSON.parse usage (#40710)
e721a5d 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update type castings for JSON.parse usage (#40710)
2c90391 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(dev-infra): update type castings for JSON.parse usage (#40710)
cbdb5e2 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update build tooling for latest changes in rules_nodejs (#…
696f7bc 
…40710)

Update the build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(dev-infra): update build tooling for latest changes in rules_node…
aec2a2c 
…js (#40710)

Update the build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(compiler-cli): update ngcc integration tests for latest changes i…
d7f5755 
…n rules_nodejs (#40710)

Update the ngcc integration tests to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
build: update to rules_nodejs@3.1.0 (#40710)
98defb6 
Update to the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(bazel): update integration test to use rules_nodejs@3.1.0 (#40710)
63f6273 
Update the integraiton tests for bazel to the latest rules_nodejs version.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
build: update tools directory for latest changes in rules_nodejs (#40710
22f734f 
)

Update the scripts/tooling in the tools directory to handle the changes in the latest
version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(zone.js): update build tooling for latest changes in rules_nodejs (…
86a6be7 
…#40710)

Update the zone.js build tooling to handle the changes in the latest version of rules_nodejs.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(service-worker): update type castings for JSON.parse usage (#40710)
900bc87 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
alxhub pushed a commit that referenced this pull request Feb 9, 2021
@josephperrott @alxhub
fix(router): update type castings for JSON.parse usage (#40710)
35c3d80 
Update usages of JSON.parse to be cast as specific types.

PR Close #40710
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Mar 12, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 left review comments

@AndrewKushnir AndrewKushnir AndrewKushnir left review comments

+2 more reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules area: benchpress area: build & ci Related the build and CI infrastructure of the project area: compiler Issues related to `ngc`, Angular's template compiler area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) area: elements Issues related to Angular Elements area: i18n Issues related to localization and internationalization area: router area: service-worker Issues related to the @angular/service-worker package area: testing Issues related to Angular testing features, such as TestBed area: zones Issues related to zone.js cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@josephperrott @alan-agius4 @petebacondarwin @IgorMinar @AndrewKushnir