fix(zone.js): fix typo in zone_externs#40348
Closed
pwwpche wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
This change fixes a typo in zone.js externs definition and avoids Closure compiler renaming Task.cancelScheduleRequest() unexpectedly.
mhevery
approved these changes
Jan 8, 2021
atscott
pushed a commit
that referenced
this pull request
Jan 8, 2021
This change fixes a typo in zone.js externs definition and avoids Closure compiler renaming Task.cancelScheduleRequest() unexpectedly. PR Close #40348
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a typo in zone.js externs definition and avoids Closure
compiler renaming Task.cancelScheduleRequest() unexpectedly.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There are two scripts loaded in the browser:
When app.js runs, getting error "zone.Xlb is not a function", because Closure renames cancelScheduleRequest().
Issue Number: N/A
What is the new behavior?
app.js loads without throwing this error.
Does this PR introduce a breaking change?
Other information