Skip to content

refactor(core): Replace non-null assertion operator with property initialization#39730

Closed
mhevery wants to merge 1 commit intomasterfrom
pr/34293
Closed

refactor(core): Replace non-null assertion operator with property initialization#39730
mhevery wants to merge 1 commit intomasterfrom
pr/34293

Conversation

@mhevery
Copy link
Contributor

@mhevery mhevery commented Nov 18, 2020

This is a fixup of #34293

(The original author has since deleted their branch and so in place fixup was not possible.)

@google-cla
Copy link

google-cla bot commented Nov 18, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 18, 2020
@mhevery mhevery requested a review from atscott November 18, 2020 03:24
@mhevery mhevery added cla: yes and removed cla: no labels Nov 18, 2020
@mhevery mhevery mentioned this pull request Nov 18, 2020
Closed
14 tasks
@mhevery
Copy link
Contributor Author

mhevery commented Nov 18, 2020

presubmit

@kubk @mhevery
refactor(core): Replace non-null assertion operator with property ini…
c928199 
…tialization

Reuse the `noop` function from the common utilities
@google-cla
Copy link

google-cla bot commented Nov 18, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 18, 2020
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release and removed cla: no labels Nov 18, 2020
@ngbot
Copy link

ngbot bot commented Nov 18, 2020

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "cla/google" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

alfaproject
alfaproject reviewed Nov 18, 2020
View reviewed changes
packages/core/test/bundling/forms/bundle.golden_symbols.json
"name": "noop"
},
{
"name": "noop"
Copy link
Contributor

@alfaproject alfaproject Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this is repeated o:

@atscott atscott closed this in 6fbe219 Nov 18, 2020
atscott pushed a commit that referenced this pull request Nov 18, 2020
@kubk @atscott
refactor(core): Replace non-null assertion operator with property ini…
5d8b5eb 
…tialization (#39730)

Reuse the `noop` function from the common utilities

PR Close #39730
@mhevery mhevery deleted the pr/34293 branch November 18, 2020 18:40
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 20, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 20, 2020
@pullapprove pullapprove bot added the area: core Issues related to the framework runtime label Dec 20, 2020
@ngbot ngbot bot added this to the Backlog milestone Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

+1 more reviewer

@alfaproject alfaproject alfaproject left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@mhevery @alfaproject @atscott @kubk