feat(compiler): Recover on malformed keyed reads and keyed writes#39004
Closed
ayazhafiz wants to merge 5 commits intoangular:masterfrom
Closed
feat(compiler): Recover on malformed keyed reads and keyed writes#39004ayazhafiz wants to merge 5 commits intoangular:masterfrom
ayazhafiz wants to merge 5 commits intoangular:masterfrom
Conversation
ayazhafiz
commented
Sep 26, 2020
Comment on lines
214
to
221
Contributor
Author
There was a problem hiding this comment.
I think it is okay to keep both errors here, but an argument could be made that they are overlapping. Let me know what you think.
atscott
reviewed
Sep 28, 2020
Contributor
There was a problem hiding this comment.
I feel like it would almost be worth adding these to a separate test(compiler) commit before the changes to the code to make it clear that we were already able to recover from errors in keyed reads and that the changes only affect keyed writes.
Contributor
Author
There was a problem hiding this comment.
Makes sense, I will do this.
alxhub
approved these changes
Oct 1, 2020
Comment on lines
214
to
221
JoostK
reviewed
Oct 2, 2020
This patch adds support for recovering well-formed (and near-complete) ASTs for semantically malformed keyed reads and keyed writes. See the added tests for details on the types of semantics we can now recover; in particular, notice that some assumptions are made about the form of a keyed read/write intended by a user. For example, in the malformed expression `a[1 + = 2`, we assume that the user meant to write a binary expression for the key of `a`, and assign that key the value `2`. In particular, we now parse this as `a[1 + <empty expression>] = 2`. There are some different interpretations that can be made here, but I think this is reasonable. The actual changes in the parser code are fairly minimal (a nice surprise!); the biggest addition is a `writeContext` that marks whether the `=` operator can serve as a recovery point after error detection. Part of angular#38596
b5cf760 to
c93b550
Compare
JoostK
approved these changes
Oct 2, 2020
Contributor
Author
|
Caretaker: can you run presubmit? |
Contributor
josephperrott
pushed a commit
that referenced
this pull request
Oct 2, 2020
…9004) This patch adds support for recovering well-formed (and near-complete) ASTs for semantically malformed keyed reads and keyed writes. See the added tests for details on the types of semantics we can now recover; in particular, notice that some assumptions are made about the form of a keyed read/write intended by a user. For example, in the malformed expression `a[1 + = 2`, we assume that the user meant to write a binary expression for the key of `a`, and assign that key the value `2`. In particular, we now parse this as `a[1 + <empty expression>] = 2`. There are some different interpretations that can be made here, but I think this is reasonable. The actual changes in the parser code are fairly minimal (a nice surprise!); the biggest addition is a `writeContext` that marks whether the `=` operator can serve as a recovery point after error detection. Part of #38596 PR Close #39004
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for recovering well-formed (and near-complete)
ASTs for semantically malformed keyed reads and keyed writes. See the
added tests for details on the types of semantics we can now recover;
in particular, notice that some assumptions are made about the form of
a keyed read/write intended by a user. For example, in the malformed
expression
a[1 + = 2, we assume that the user meant to write a binaryexpression for the key of
a, and assign that key the value2. Inparticular, we now parse this as
a[1 + <empty expression>] = 2. Thereare some different interpretations that can be made here, but I think
this is reasonable.
The actual changes in the parser code are fairly minimal (a nice
surprise!); the biggest addition is a
writeContextthat marks whetherthe
=operator can serve as a recovery point after error detection.Part of #38596
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?