fix(zone.js): zone.js package.json should not include files/directories fields#38528
Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Closed
fix(zone.js): zone.js package.json should not include files/directories fields#38528JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Conversation
…es field Close angular#38526, angular#38516, angular#38513 After update to `APF`, the `directories` and `files` options are not compatible, so we need to remove those fileds to make sure everything work as expected.
|
@mhevery put down the next version of Angular or whatever you're working on, and approve this please. |
Contributor
|
@anothermarkus - please be aware that @mhevery is in USA, and so is not yet awake. Please bear with us while we resolve this problem. |
petebacondarwin
approved these changes
Aug 19, 2020
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
Reviewed-for: required-minimum-review
I downloaded the generated npm tgz for zone.js from the publish_packages_as_artifacts job and confirmed that the files are there.
subratpalhar92
pushed a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this pull request
Aug 29, 2020
…es field (angular#38528) Close angular#38526, angular#38516, angular#38513 After update to `APF`, the `directories` and `files` options are not compatible, so we need to remove those fileds to make sure everything work as expected. PR Close angular#38528
subratpalhar92
added a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this pull request
Aug 31, 2020
…irectories field (angular#38528)" This reverts commit caba930.
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…es field (angular#38528) Close angular#38526, angular#38516, angular#38513 After update to `APF`, the `directories` and `files` options are not compatible, so we need to remove those fileds to make sure everything work as expected. PR Close angular#38528
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #38526, #38516, #38517
After update to
APF, thedirectoriesandfilesoptions are not compatible,so we need to remove those fileds to make sure everything work as expected.