fix(router): support lazy loading for empty path named outlets#38379
Closed
atscott wants to merge 3 commits intoangular:masterfrom
Closed
fix(router): support lazy loading for empty path named outlets#38379atscott wants to merge 3 commits intoangular:masterfrom
atscott wants to merge 3 commits intoangular:masterfrom
Conversation
14 tasks
380893e to
f1c97e2
Compare
acohenOT
reviewed
Aug 9, 2020
71a6595 to
ac00cdd
Compare
3 tasks
Contributor
Author
alxhub
approved these changes
Aug 17, 2020
ac00cdd to
39a8403
Compare
acohenOT
reviewed
Aug 17, 2020
acohenOT
reviewed
Aug 17, 2020
196bf2f to
fe12333
Compare
subratpalhar92
added a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this pull request
Aug 31, 2020
angular#38379)" This reverts commit 68e36dc.
In general, the router only matches and loads a single Route config tree. However, named outlets with empty paths are a special case where the router can and should actually match two different `Route`s and ensure that the modules are loaded for each match. This change updates the "ApplyRedirects" stage to ensure that named outlets with empty paths finish loading their configs before proceeding to the next stage in the routing pipe. This is necessary because if the named outlet has `loadChildren` but the associated lazy config is not loaded before following stages attempt to match and activate relevant `Route`s, an error will occur. fixes angular#12842
1333aee to
0a52656
Compare
Contributor
Author
|
@alxhub PTAL The internal failure was due to a stack overflow caused by the
This has the added benefit of loading all matched outlets concurrently. Additionally, the |
c9e6957 to
a46f081
Compare
alxhub
approved these changes
Sep 2, 2020
a46f081 to
ac2d84d
Compare
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
12 tasks
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…ar#38379) In general, the router only matches and loads a single Route config tree. However, named outlets with empty paths are a special case where the router can and should actually match two different `Route`s and ensure that the modules are loaded for each match. This change updates the "ApplyRedirects" stage to ensure that named outlets with empty paths finish loading their configs before proceeding to the next stage in the routing pipe. This is necessary because if the named outlet has `loadChildren` but the associated lazy config is not loaded before following stages attempt to match and activate relevant `Route`s, an error will occur. fixes angular#12842 PR Close angular#38379
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
angular#38379)" This reverts commit 7ad3264.
|
hi guys, any update on that? Stuck with this issue and need this PR |
Contributor
Author
|
@danylobilokha it’s available in the v11 release, currently 11.0.0-next.2 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, the router only matches and loads a single Route config tree. However,
named outlets with empty paths are a special case where the router can
and should actually match two different
Routes and ensure that themodules are loaded for each match.
This change updates the "ApplyRedirects" stage to ensure that named
outlets with empty paths finish loading their configs before proceeding
to the next stage in the routing pipe. This is necessary because if the
named outlet has
loadChildrenbut the associated lazy config is not loadedbefore following stages attempt to match and activate relevant
Routes,an error will occur.
fixes #12842
global presubmit - Will want to do another rerun as I made a tiny change since then to pass the test "should work work with redirects when other outlet comes before the one being activated"