Skip to content

build(forms): create sample forms app#38044

Closed
sonukapoor wants to merge 5 commits intoangular:masterfrom
sonukapoor:forms-demo-app
Closed

build(forms): create sample forms app#38044
sonukapoor wants to merge 5 commits intoangular:masterfrom
sonukapoor:forms-demo-app

Conversation

@sonukapoor
Copy link
Contributor

@sonukapoor sonukapoor commented Jul 14, 2020 •
edited
Loading

This commit creates a sample forms test application to introduce the symbol tests. It serves as a guard to ensure that any future work on the forms package does not unintentionally increase the payload size.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@sonukapoor sonukapoor force-pushed the forms-demo-app branch 4 times, most recently from 970efc7 to e708b77 Compare July 14, 2020 13:55
@sonukapoor sonukapoor changed the title buid(ivy): create sample forms app build(forms): create sample forms app Jul 14, 2020
@googlebot

This comment has been minimized.

Sign in to view
@devversion
Copy link
Member

devversion commented Jul 15, 2020

@googlebot I consent.

@googlebot

This comment has been minimized.

Sign in to view
@sonukapoor sonukapoor force-pushed the forms-demo-app branch 2 times, most recently from 0550005 to f162a45 Compare July 15, 2020 10:35
@sonukapoor sonukapoor marked this pull request as ready for review July 15, 2020 10:37
@pullapprove pullapprove bot requested review from AndrewKushnir and IgorMinar July 15, 2020 10:37
@ngbot ngbot bot added this to the needsTriage milestone Jul 16, 2020
AndrewKushnir
AndrewKushnir requested changes Jul 17, 2020
View reviewed changes
AndrewKushnir
AndrewKushnir reviewed Jul 17, 2020
View reviewed changes
@sonukapoor
Copy link
Contributor Author

sonukapoor commented Jul 18, 2020

@AndrewKushnir ci failed for some reason. I have added the PR action: rerun CI at HEAD

@sonukapoor
build(forms): create sample forms app
d0e8b27 
This commit creates a sample forms test application to introduce the symbol
tests. It serves as a guard to ensure that any future work on the
forms package does not unintentionally increase the payload size.
@sonukapoor
fixup! build(forms): create sample forms app
a95bafb
AndrewKushnir
AndrewKushnir reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one final comment (indentation in a template). Thanks Sonu!

You'll also need to rebase, since there are new symbols that should be included into the golden file.

@pullapprove pullapprove bot requested review from devversion and removed request for IgorMinar July 22, 2020 02:09
@AndrewKushnir AndrewKushnir added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jul 22, 2020
@sonukapoor sonukapoor requested a review from AndrewKushnir July 22, 2020 12:20
AndrewKushnir
AndrewKushnir approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment on template formatting.

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Jul 22, 2020

FYI, I also changed the PR target to master-only, since the golden file would be slightly different between master and patch (thus this PR will cause CI errors on patch branch). I think having it only in master is OK and it will become a part of the patch branch after 10.1.0 release. Thank you.

@sonukapoor
Copy link
Contributor Author

sonukapoor commented Jul 22, 2020

@AndrewKushnir My bad about the indentation. It should be fixed now.

devversion
devversion approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few minor nits for the BUILD configuration

@devversion devversion added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 23, 2020
devversion
devversion approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 23, 2020
@mhevery mhevery closed this in 7b2e2f5 Jul 23, 2020
@sonukapoor sonukapoor deleted the forms-demo-app branch July 23, 2020 18:26
Splaktar pushed a commit to angular-hispano/angular that referenced this pull request Aug 8, 2020
@sonukapoor @Splaktar
build(forms): create sample forms app (angular#38044)
06356d8 
This commit creates a sample forms test application to introduce the symbol
tests. It serves as a guard to ensure that any future work on the
forms package does not unintentionally increase the payload size.

PR Close angular#38044
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 23, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 23, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@sonukapoor @profanis
build(forms): create sample forms app (angular#38044)
7333310 
This commit creates a sample forms test application to introduce the symbol
tests. It serves as a guard to ensure that any future work on the
forms package does not unintentionally increase the payload size.

PR Close angular#38044
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@sonukapoor @googlebot @devversion @AndrewKushnir