fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3TestBed#30037
Closed
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Closed
fix(ivy): explicitly compile ngModuleDef for RootScopeModule in R3TestBed#30037AndrewKushnir wants to merge 1 commit intoangular:masterfrom
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Conversation
…tBed This commit unifies the way auxillary RootScopeModule and DynamicTestModule are compiled in R3TestBed by calling `compileNgModuleDefs` explicitly for RootScopeModule. This change also resolves the problem where TestBed's code was used from the @angular/core NPM package: due to the "jit" flag, the @NgModule decorator on the RootScopeModule was transformed to RootScopeModule.decorators = [...], but actual ngModuleDef was never defined.
Contributor
16 tasks
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
May 1, 2019
Previously, `R3TestBedCompiler` was dynamically defining an `@NgModule`-decorated `CompilerModule` class inside a method call. Since ngcc only processes top-level classes, this class was not transformed causing failures in unit tests (see angular#30121 for details). This commit fixes it by using `compileNgModuleDefs()` directly (similar to the fix in angular#30037). Fixes angular#30121
kara
pushed a commit
that referenced
this pull request
May 1, 2019
…28530) Previously, `R3TestBedCompiler` was dynamically defining an `@NgModule`-decorated `CompilerModule` class inside a method call. Since ngcc only processes top-level classes, this class was not transformed causing failures in unit tests (see #30121 for details). This commit fixes it by using `compileNgModuleDefs()` directly (similar to the fix in #30037). Fixes #30121 PR Close #28530
kara
pushed a commit
that referenced
this pull request
May 1, 2019
…28530) Previously, `R3TestBedCompiler` was dynamically defining an `@NgModule`-decorated `CompilerModule` class inside a method call. Since ngcc only processes top-level classes, this class was not transformed causing failures in unit tests (see #30121 for details). This commit fixes it by using `compileNgModuleDefs()` directly (similar to the fix in #30037). Fixes #30121 PR Close #28530
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…tBed (angular#30037) This commit unifies the way auxillary RootScopeModule and DynamicTestModule are compiled in R3TestBed by calling `compileNgModuleDefs` explicitly for RootScopeModule. This change also resolves the problem where TestBed's code was used from the @angular/core NPM package: due to the "jit" flag, the @NgModule decorator on the RootScopeModule was transformed to RootScopeModule.decorators = [...], but actual ngModuleDef was never defined. PR Close angular#30037
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ngular#28530) Previously, `R3TestBedCompiler` was dynamically defining an `@NgModule`-decorated `CompilerModule` class inside a method call. Since ngcc only processes top-level classes, this class was not transformed causing failures in unit tests (see angular#30121 for details). This commit fixes it by using `compileNgModuleDefs()` directly (similar to the fix in angular#30037). Fixes angular#30121 PR Close angular#28530
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit unifies the way auxiliary RootScopeModule and DynamicTestModule are compiled in R3TestBed by calling
compileNgModuleDefsexplicitly for RootScopeModule. This change also resolves the problem where TestBed's code was used from the @angular/core NPM package: due to the "jit" flag, the @NgModule decorator on the RootScopeModule was transformed to RootScopeModule.decorators = [...], but actual ngModuleDef was never defined.This PR resolves FW-1280.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?